Files that are in src/ui/base should be compiled into libui_base.a.

Files that are in src/ui/base should be compiled into libui_base.a.

Move files that are still in app_base over to ui_base.

BUG=72317
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87369

[tfarina, 2011-05-28 02:20:10]

Isn't this BUG=72317?

[brettw, 2011-05-29 04:51:27]

LGTM to the extent I can

[Robert Sesek, 2011-05-29 17:15:56]

LGTM with a few nits

http://codereview.chromium.org/7082017/diff/2001/app/app_base.gypi
File app/app_base.gypi (left):

http://codereview.chromium.org/7082017/diff/2001/app/app_base.gypi#oldcode10
app/app_base.gypi:10: 'msvs_guid': '4631946D-7D5F-44BD-A5A8-504C0A7033BE',
Did you mean to remove this?

http://codereview.chromium.org/7082017/diff/2001/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/7082017/diff/2001/printing/printing.gyp#newcode20
printing/printing.gyp:20: '../ui/ui.gyp:ui_base',  # Only required for Font
support
nit: full-stop comments

http://codereview.chromium.org/7082017/diff/2001/tools/memory_watcher/memory_...
File tools/memory_watcher/memory_watcher.gyp (right):

http://codereview.chromium.org/7082017/diff/2001/tools/memory_watcher/memory_...
tools/memory_watcher/memory_watcher.gyp:1: # Copyright (c) 2009 The Chromium
Authors. All rights reserved.
2011

http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi
File ui/ui_base.gypi (right):

http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi#newcode225
ui/ui_base.gypi:225: },{  # use_x11==0
nit: space after ,

[tfarina, 2011-05-30 15:46:42]

http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi
File ui/ui_base.gypi (right):

http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi#newcode96
ui/ui_base.gypi:96: 'base/l10n/l10n_util.h',
put this right after l10n_util.cc?

http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi#newcode114
ui/ui_base.gypi:114: 'base/models/menu_model.h',
put this right after menu_model.cc?

[tony, 2011-05-31 18:56:38]

On 2011/05/28 02:20:10, tfarina wrote:
> Isn't this BUG=72317?

Yes, thanks for that.

On 2011/05/29 17:15:56, rsesek wrote:
> LGTM with a few nits
> 
> http://codereview.chromium.org/7082017/diff/2001/app/app_base.gypi
> File app/app_base.gypi (left):
> 
> http://codereview.chromium.org/7082017/diff/2001/app/app_base.gypi#oldcode10
> app/app_base.gypi:10: 'msvs_guid': '4631946D-7D5F-44BD-A5A8-504C0A7033BE',
> Did you mean to remove this?

I did, but I think it should be in a separate change.  I put it back.

> http://codereview.chromium.org/7082017/diff/2001/printing/printing.gyp
> File printing/printing.gyp (right):
> 
>
http://codereview.chromium.org/7082017/diff/2001/printing/printing.gyp#newcode20
> printing/printing.gyp:20: '../ui/ui.gyp:ui_base',  # Only required for Font
> support
> nit: full-stop comments

Done.

>
http://codereview.chromium.org/7082017/diff/2001/tools/memory_watcher/memory_...
> File tools/memory_watcher/memory_watcher.gyp (right):
> 
>
http://codereview.chromium.org/7082017/diff/2001/tools/memory_watcher/memory_...
> tools/memory_watcher/memory_watcher.gyp:1: # Copyright (c) 2009 The Chromium
> Authors. All rights reserved.
> 2011

Done.

> http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi
> File ui/ui_base.gypi (right):
> 
> http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi#newcode225
> ui/ui_base.gypi:225: },{  # use_x11==0
> nit: space after ,

Done.

On 2011/05/30 15:46:42, tfarina wrote:
> http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi
> File ui/ui_base.gypi (right):
> 
> http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi#newcode96
> ui/ui_base.gypi:96: 'base/l10n/l10n_util.h',
> put this right after l10n_util.cc?

Done (although technically this doesn't follow C sort, but it seems more
consistent with other .gyp files).

> http://codereview.chromium.org/7082017/diff/2001/ui/ui_base.gypi#newcode114
> ui/ui_base.gypi:114: 'base/models/menu_model.h',
> put this right after menu_model.cc?

Done.

Will try to land via the commit bot.

[commit-bot: I haz the power, 2011-05-31 21:40:42]

Change committed as 87369