Issue 7082004: Revert 86422 - Make DHCP WPAD on by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7082004: Revert 86422 - Make DHCP WPAD on by default. (Closed)

Created:
9 years, 7 months ago by Jói

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., eroman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert 86422 - Make DHCP WPAD on by default. Reason: Turning off for M13 branch based on some concerns from user experience metrics. Will re-enable after M13 branch point. BUG=18575, 84047 TEST=Run Chrome on Windows without any flags. Enable auto-detect in proxy configuration. Net log should show attempts to auto-detect via DHCP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87047

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -17 lines)			Patch
M	chrome/browser/net/connection_tester.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/proxy_service_factory.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	net/proxy/dhcp_proxy_script_fetcher_factory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/proxy/dhcp_proxy_script_fetcher_factory.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc	View	2 chunks	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

This is a straight revert of r86422. Will submit TBR once try bots pass as ...

9 years, 7 months ago (2011-05-27 15:39:54 UTC) #1

LGTM.

Expand Messages | Collapse Messages