Issue 7080064: [Mac] Refactor the logic of tab dragging out of TabView and into a new helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7080064: [Mac] Refactor the logic of tab dragging out of TabView and into a new helper. (Closed)

Created:
9 years, 6 months ago by Robert Sesek

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Mac] Refactor the logic of tab dragging out of TabView and into a new helper. The helper TabStripDragController is owned by the TabStripController. It operates using the TabDraggingEventTarget protocol, which is used to pass the mouse events from the TabView up through various controllers to the DragController. This CL introduces no behavioral changes and is just preparatory work for being able to drag multiple tabs. BUG=78816 TEST=Drag tabs in and out of the tab strip. Everything works as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88125

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+695 lines, -518 lines)			Patch
M	chrome/browser/ui/cocoa/tabs/tab_controller.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_controller.mm	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_controller_target.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View	3 chunks	+8 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h	View	1 chunk	+83 lines, -0 lines	1 comment	Download
A	chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm	View	1 chunk	+523 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_view.h	View	2 chunks	+3 lines, -30 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_view.mm	View	7 chunks	+36 lines, -487 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

9 years, 6 months ago (2011-06-03 14:24:49 UTC) #2

LGTM, thanks for cleaning this up

http://codereview.chromium.org/7080064/diff/1/chrome/browser/ui/cocoa/tabs/ta...
File chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h (right):

http://codereview.chromium.org/7080064/diff/1/chrome/browser/ui/cocoa/tabs/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h:54: // TODO(alcor):
these references may need to be strong to avoid crashes
you can probably remove this TODO at this point.

Expand Messages | Collapse Messages