Issue 7080053: Make instanceof and Object.getPrototypeOf work for proxies, plus a few other tweaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7080053: Make instanceof and Object.getPrototypeOf work for proxies, plus a few other tweaks. (Closed)

Created:
9 years, 6 months ago by rossberg

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make instanceof and Object.getPrototypeOf work for proxies, plus a few other tweaks. R=kmillikin@chromium.org

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -25 lines)			Patch
M	src/messages.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/proxy.js	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/runtime.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+25 lines, -2 lines	0 comments	Download
M	src/v8natives.js	View	4 chunks	+39 lines, -2 lines	1 comment	Download
M	src/x64/builtins-x64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/harmony/proxies.js	View	2 chunks	+72 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 6 months ago (2011-06-01 15:14:31 UTC) #2

LGTM.

http://codereview.chromium.org/7080053/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7080053/diff/1/src/v8natives.js#newcode406
src/v8natives.js:406: if (!("value" in desc)) desc.value = undefined
undefined ==> void 0

Expand Messages | Collapse Messages