chrome/browser/safe_browsing/client_side_detection_service.cc - Issue 7080034: Currently, there is a bug in the way we show the csd phishing interstitial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.cc

Issue 7080034: Currently, there is a bug in the way we show the csd phishing interstitial. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix tests and add some logging. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/client_side_detection_host.cc ('K') | « chrome/browser/safe_browsing/client_side_detection_host_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.h » ('j') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc

index 70ec7bfef0511535a7227592da63ce878d4d0170..e3f412f1ac23c53aeac66886e8a65a5ce9962fbb 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service.cc

@@ -188,6 +188,7 @@ void ClientSideDetectionService::SendModelToProcess(

::DuplicateHandle(::GetCurrentProcess(), model_file_, process->GetHandle(),

&file, 0, false, DUPLICATE_SAME_ACCESS);

#endif

+ VLOG(2) << "Sending phishing model to renderer";

process->Send(new SafeBrowsingMsg_SetPhishingModel(file));

}