Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 7080024: Mac: Part 1 of a fix to get OOP font loading working in the renderer on 10.6.6 . (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_message_filter.h ('k') | content/common/font_loader_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index efdb533b0f2d70eaa56c82221e0905d0de5c1d64..960d1913a2ae0a1c1dbe7d8e7411ee975aca6a7f 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -533,16 +533,19 @@ void RenderMessageFilter::OnCookiesEnabled(
#if defined(OS_MACOSX)
void RenderMessageFilter::OnLoadFont(const FontDescriptor& font,
uint32* handle_size,
- base::SharedMemoryHandle* handle) {
+ base::SharedMemoryHandle* handle,
+ uint32* font_id) {
base::SharedMemory font_data;
uint32 font_data_size = 0;
bool ok = FontLoader::LoadFontIntoBuffer(font.ToNSFont(), &font_data,
- &font_data_size);
- if (!ok || font_data_size == 0) {
+ &font_data_size, font_id);
+ if (!ok || font_data_size == 0 || *font_id == 0) {
LOG(ERROR) << "Couldn't load font data for " << font.font_name <<
- " ok=" << ok << " font_data_size=" << font_data_size;
+ " ok=" << ok << " font_data_size=" << font_data_size <<
+ " font id=" << *font_id;
*handle_size = 0;
*handle = base::SharedMemory::NULLHandle();
+ *font_id = 0;
return;
}
« no previous file with comments | « content/browser/renderer_host/render_message_filter.h ('k') | content/common/font_loader_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698