chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm - Issue 7080012: Mac. Make wrench menu controller ignore embedded ampersand (Windows accelerator key marker) in bo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm

Issue 7080012: Mac. Make wrench menu controller ignore embedded ampersand (Windows accelerator key marker) in bo... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm

===================================================================

--- chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm (revision 86919)

+++ chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm (working copy)

@@ -107,7 +107,10 @@

- (NSMenu*)bookmarkSubMenu {

NSString* title = l10n_util::GetNSString(IDS_BOOKMARKS_MENU);

- return [[[self menu] itemWithTitle:title] submenu];

+ // Strip windows accelerator mark.

+ NSString* processedTitle = [title stringByReplacingOccurrencesOfString:@"&"

+ withString:@""];

Avi (use Gerrit) 2011/05/27 21:08:09 NAK. This is what l10n_util::GetNSStringWithFixup

mafv 2011/05/27 21:22:28 Done.

+ return [[[self menu] itemWithTitle:processedTitle] submenu];

}

- (void)updateBookmarkSubMenu {

« no previous file with comments | « no previous file | no next file » | no next file with comments »