Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 7080012: Mac. Make wrench menu controller ignore embedded ampersand (Windows accelerator key marker) in bo... (Closed)

Created:
9 years, 7 months ago by mafv
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Mac. Make wrench menu controller ignore embedded ampersand (Windows accelerator key marker) in bookmark submenu resource name when looking for the submenu. See http://codereview.chromium.org/7082011/ R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87132

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mafv
9 years, 7 months ago (2011-05-27 21:03:11 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/7080012/diff/1/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm (right): http://codereview.chromium.org/7080012/diff/1/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm#newcode112 chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm:112: withString:@""]; NAK. This is what l10n_util::GetNSStringWithFixup is for.
9 years, 7 months ago (2011-05-27 21:08:09 UTC) #2
mafv
http://codereview.chromium.org/7080012/diff/1/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm (right): http://codereview.chromium.org/7080012/diff/1/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm#newcode112 chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm:112: withString:@""]; On 2011/05/27 21:08:09, Avi wrote: > NAK. This ...
9 years, 7 months ago (2011-05-27 21:22:28 UTC) #3
Avi (use Gerrit)
9 years, 7 months ago (2011-05-27 21:27:46 UTC) #4
ACK.

LGTM

Powered by Google App Engine
This is Rietveld 408576698