Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3702)

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

Issue 7077033: Convert BrowserActionOverflowMenu context menu from Menu2 to MenuItemView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implement reveiwer recommendation. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
index 23f2f6bcf4cb35d1592218b256d8017c6d96bbc4..3267e702507cb296244eefc9ab5e86c64a51a6e5 100644
--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
@@ -13,8 +13,10 @@
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_action.h"
#include "ui/gfx/canvas_skia.h"
-#include "views/controls/menu/menu_2.h"
#include "views/controls/menu/menu_item_view.h"
+#include "views/controls/menu/menu_model_adapter.h"
+#include "views/controls/menu/submenu_view.h"
+#include "views/window/window.h"
BrowserActionOverflowMenuController::BrowserActionOverflowMenuController(
BrowserActionsContainer* owner,
@@ -96,13 +98,16 @@ bool BrowserActionOverflowMenuController::ShowContextMenu(
if (!extension->ShowConfigureContextMenus())
return false;
- context_menu_contents_ = new ExtensionContextMenuModel(
- extension,
- owner_->browser(),
- owner_);
- context_menu_menu_.reset(new views::Menu2(context_menu_contents_.get()));
+ scoped_refptr<ExtensionContextMenuModel> context_menu_contents =
+ new ExtensionContextMenuModel(extension, owner_->browser(), owner_);
+ views::MenuModelAdapter context_menu_model_adapter(
+ context_menu_contents.get());
+ views::MenuItemView context_menu_menu(&context_menu_model_adapter);
Peter Kasting 2011/06/09 17:44:51 Nit: Can this just be |context_menu|? Or |context
rhashimoto 2011/06/09 19:00:02 Done.
+ context_menu_model_adapter.BuildMenu(&context_menu_menu);
+
// This blocks until the user choses something or dismisses the menu.
- context_menu_menu_->RunContextMenuAt(p);
+ context_menu_menu.RunMenuAt(menu_button_->GetWidget()->GetNativeWindow(),
+ NULL, gfx::Rect(p, gfx::Size()), views::MenuItemView::TOPLEFT, true);
// The user is done with the context menu, so we can close the underlying
// menu.
« no previous file with comments | « chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698