Issue 7077019: Unbranch libjingle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7077019: Unbranch libjingle (Closed)

Created:
9 years, 7 months ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
Wez, Alpha Left Google

CC:
chromium-reviews, joi+watch-content_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Unbranch libjingle BUG=35195, 76790 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86954

Patch Set 1 #

Patch Set 2 : update test code #

Patch Set 3 : - #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -69 lines)			Patch
M	DEPS	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/p2p/ipc_socket_factory.cc	View		10 chunks	+47 lines, -47 lines	0 comments	Download
M	jingle/glue/fake_socket_factory.h	View	1	1 chunk	+6 lines, -7 lines	0 comments	Download
M	jingle/glue/fake_socket_factory.cc	View	1 2	4 chunks	+11 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM too. One question; the GetLocalAddress API has revert to not indicate whether an address ...

9 years, 7 months ago (2011-05-26 22:29:30 UTC) #3

Sergey Ulanov

9 years, 7 months ago (2011-05-26 22:50:37 UTC) #4

On 2011/05/26 22:29:30, Wez wrote:
> LGTM too.
> 
> One question; the GetLocalAddress API has revert to not indicate whether an
> address is available.  Why is it we don't need that any longer?
The interface was changed: now the caller should use GetState() to verify state
of the AsyncPacketSocket. If state is set to STATE_BINDING the address returned
by GetLocalAddress() may be invalid.

Expand Messages | Collapse Messages