Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 7077014: Promoting the MHTML file extension to primary mappings. (Closed)

Created:
9 years, 7 months ago by Jay Civelli
Modified:
9 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, adamk
Visibility:
Public.

Description

Promoting the MHTML file extension to primary mappings. This CL promotes the MHTML file extensions to the MIME primary mappings. This is to to make MHTML work on Windows. Windows associates the message/rfc822 MIME type with MHTML files, and we use the less mail specific multipart/related on the WebKit side. BUG=83833 TEST=MHTML layout tests should pass on Windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88959

Patch Set 1 #

Total comments: 1

Patch Set 2 : Wan-Teh comment addressed #

Patch Set 3 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/base/mime_util.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jay Civelli
9 years, 7 months ago (2011-05-26 21:20:48 UTC) #1
abarth-chromium
Sounds reasonable, but I'm not a net owner.
9 years, 7 months ago (2011-05-26 22:32:39 UTC) #2
Jay Civelli
Wan-Teh, Would you mind looking at this CL? (I need a net owner to land) ...
9 years, 7 months ago (2011-05-26 22:35:49 UTC) #3
wtc
LGTM. http://codereview.chromium.org/7077014/diff/1/net/base/mime_util.cc File net/base/mime_util.cc (right): http://codereview.chromium.org/7077014/diff/1/net/base/mime_util.cc#newcode99 net/base/mime_util.cc:99: { "multipart/related", "mht,mhtml" } Nit: it seems better ...
9 years, 7 months ago (2011-05-27 17:21:12 UTC) #4
commit-bot: I haz the power
9 years, 6 months ago (2011-06-14 05:21:44 UTC) #5
Change committed as 88959

Powered by Google App Engine
This is Rietveld 408576698