Issue 7077012: Removed all references to v8/src from i18n extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7077012: Removed all references to v8/src from i18n extension code. (Closed)

Created:
9 years, 7 months ago by Nebojša Ćirić

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Removed all references to v8/src from i18n extension code. Removed I18N enum from v8/src/natives.h Removed use of Vector and natives.h from i18n-extension.cc. Added new python script that generates i18n-js.cc from i18n.js. Made all paths absolute pointing to either v8/include or v8/src/extensions/experimental. Exported -Iv8 for embedders (-Iv8/include was there already). Committed: http://code.google.com/p/v8/source/detail?r=8127

Patch Set 1 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+204 lines, -38 lines)			Patch
M	src/extensions/experimental/break-iterator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/extensions/experimental/break-iterator.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/extensions/experimental/collator.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/extensions/experimental/collator.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/extensions/experimental/experimental.gyp	View	4 chunks	+11 lines, -4 lines	0 comments	Download
M	src/extensions/experimental/i18n-extension.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/extensions/experimental/i18n-extension.cc	View	1 chunk	+6 lines, -16 lines	0 comments	Download
A	src/extensions/experimental/i18n-js2c.py	View	1 chunk	+126 lines, -0 lines	0 comments	Download
M	src/extensions/experimental/i18n-locale.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/extensions/experimental/i18n-locale.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
A	src/extensions/experimental/i18n-natives.h	View	1 chunk	+43 lines, -0 lines	0 comments	Download
M	src/extensions/experimental/i18n-utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/extensions/experimental/language-matcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/extensions/experimental/language-matcher.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

I've tested componentized build on linux and windows, and static build on linux. I've also ...

9 years, 7 months ago (2011-05-26 23:43:54 UTC) #1

LGTM, thanks for doing this Nebojša!

Expand Messages | Collapse Messages