Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 7077009: Handle AddPreload/AddPendingPreload on UI thread. (Closed)

Created:
9 years, 7 months ago by mmenke
Modified:
9 years, 7 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Determine whether or not a prerender tag comes from a currently prerendering RenderView on the UI thread, rather than the IO thread. BUG=none TEST=PrerenderBrowserTest.PrerenderInfiniteLoop (Currently FLAKY). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86968

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -67 lines) Patch
M chrome/browser/prerender/prerender_final_status.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 4 chunks +13 lines, -26 lines 0 comments Download
M chrome/browser/prerender/prerender_manager_unittest.cc View 1 chunk +4 lines, -29 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_observer.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mmenke
Not exactly a vital CL, but simplifies things a little.
9 years, 7 months ago (2011-05-26 18:54:43 UTC) #1
dominich
LGTM I thought originally that it was best to do the check on IO to ...
9 years, 7 months ago (2011-05-26 19:01:08 UTC) #2
mmenke
Thanks. I had been thinking it was an artifact of how the PrerenderResourceHandler used to ...
9 years, 7 months ago (2011-05-26 19:07:51 UTC) #3
cbentzel
LGTM
9 years, 7 months ago (2011-05-26 23:58:57 UTC) #4
commit-bot: I haz the power
9 years, 7 months ago (2011-05-27 04:11:11 UTC) #5
Change committed as 86968

Powered by Google App Engine
This is Rietveld 408576698