Issue 7077004: JSON.stringify improvement. Fast case in C++ for string arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7077004: JSON.stringify improvement. Fast case in C++ for string arrays. (Closed)

Created:
9 years, 7 months ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

JSON.stringify improvement. Fast case in C++ for string arrays.

Patch Set 4 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -46 lines)			Patch
M	src/json.js	View	1 2 3	1 chunk	+15 lines, -10 lines	0 comments	Download
M	src/runtime.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 2 3	6 chunks	+141 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3538 src/runtime.cc:3538: ASSERT(2 <= radix && radix <= 36); ASSERT ...

9 years, 7 months ago (2011-05-26 11:24:43 UTC) #2

sandholm

9 years, 7 months ago (2011-05-26 11:41:36 UTC) #3

http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3538
src/runtime.cc:3538: ASSERT(2 <= radix && radix <= 36);
On 2011/05/26 11:24:43, Lasse Reichstein wrote:
> ASSERT -> RUNTIME_ASSERT

Done.

http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3548
src/runtime.cc:3548: }
On 2011/05/26 11:24:43, Lasse Reichstein wrote:
> Maybe we should have special case for < radix^2 too, for cached two-byte
> strings.

Good idea (for another CL).

http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode5102
src/runtime.cc:5102: SinkChar* write_cursor,
On 2011/05/26 11:24:43, Lasse Reichstein wrote:
> indentation.

Done.

http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode5241
src/runtime.cc:5241: }
On 2011/05/26 11:24:43, Lasse Reichstein wrote:
> I dare you to put an
>  AssertNoAllocation no_gc;
> here.

Done.

Expand Messages | Collapse Messages

Issue 7077004: JSON.stringify improvement. Fast case in C++ for string arrays. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages