Chromium Code Reviews Chromium Code Reviews
Issue
7077003:
Roll ANGLE to r654 (Closed)
DescriptionRoll ANGLE to r654
------------------------------------------------------------------------
r654 | nduca@chromium.org | 2011-05-24 18:55:06 -0700 (Tue, 24 May 2011) | 4 lines
Use D3DSWAPEFFECT_FLIPEX on Windows 7.
Reduces frame rate jitters on Windows 7 reported in crbug.com/82925
Review URL: http://codereview.appspot.com/4517096
------------------------------------------------------------------------
r653 | daniel@transgaming.com | 2011-05-17 11:34:24 -0700 (Tue, 17 May 2011) | 3 lines
Add missing newlines to source files
Issue=154
------------------------------------------------------------------------
r652 | daniel@transgaming.com | 2011-05-17 11:34:18 -0700 (Tue, 17 May 2011) | 4 lines
Improve robustness of Context::finish and flush
Trac #16690
Signed-off-by: Nicolas Capens
------------------------------------------------------------------------
r651 | daniel@transgaming.com | 2011-05-13 09:05:22 -0700 (Fri, 13 May 2011) | 7 lines
Fix the order of the error() parameters in Surface.cpp and advertise EGL_ANGLE_d3d_share_handle_client_buffer extension
Trac #16711
Also rename the extension file to match the extension name
Signed-off-by: Nicolas Capens
------------------------------------------------------------------------
r650 | jbauman@chromium.org | 2011-05-12 16:04:07 -0700 (Thu, 12 May 2011) | 6 lines
Add support for eglCreatePbufferFromClientBuffer, taking as input a D3D share handle corresponding to the enum EGL_D3D_TEXTURE_2D_SHARE_HANDLE_ANGLE. No spec as of yet, but it does the obvious thing.
BUG=129
TEST=
Review URL: http://codereview.appspot.com/4325048
------------------------------------------------------------------------
r649 | jbauman@chromium.org | 2011-05-12 13:53:34 -0700 (Thu, 12 May 2011) | 8 lines
Use SSE2 to swizzle RGBA to BGRA
Using SSE2 can drastically reduce the amount of time it takes to do glTexImage2D. I've also added a plain-C path that's much faster than the one that was there before.
BUG=151
TEST=
Review URL: http://codereview.appspot.com/4465052
------------------------------------------------------------------------
r648 | apatrick@chromium.org | 2011-05-12 11:15:03 -0700 (Thu, 12 May 2011) | 38 lines
Cache result of D3DPERF_GetStatus.
I profiled the WebGL acquarium with AMD CodeAnalyst and it turns out this function got a lot of hits. Top 10 before change:
CS:EIP Symbol + Offset 64-bit Timer samples
0x62a87260 CBatchFilterI::ProcessBatch 13.41
0x62a171f1 D3DPERF_GetStatus 6.04
0x629ce831 CD3DBase::SetVertexShaderConstantF_FP 5.12
0x62a88bea CBatchFilterI::GetBatchBufferPointer<_LH_SETPIXELSHADERCONSTIMM_TOKEN_SMALL> 4.61
0x6298060b UpdateViewportCache 4.2
0x6298da3a CD3DBase::UpdateTextures 3.58
0x6298db6b CD3DDDIDX10::SetTexture 2.76
0x6298df1d CD3DDDIDX10::InsertStreamSource 2.46
0x629d1c1a CD3DBase::SetPixelShaderConstantF_FP 2.25
0x6297efc4 CD3DHal::SetSamplerState_FP 2.05
10 functions, 186 instructions, Total: 454 samples, 46.47% of shown samples, 2.51% of total session samples
And after:
CS:EIP Symbol + Offset 64-bit Timer samples
0x69317260 CBatchFilterI::ProcessBatch 13.87
0x69318bea CBatchFilterI::GetBatchBufferPointer<_LH_SETPIXELSHADERCONSTIMM_TOKEN_SMALL> 5.84
0x6921060b UpdateViewportCache 5.29
0x6925e831 CD3DBase::SetVertexShaderConstantF_FP 4.93
0x6921da3a CD3DBase::UpdateTextures 4.38
0x6921e034 CD3DBase::SetStreamSource_FP 3.65
0x69261c1a CD3DBase::SetPixelShaderConstantF_FP 3.65
0x69227651 CD3DBase::DrawIndexedPrimitive 2.74
0x6920efc4 CD3DHal::SetSamplerState_FP 2.37
0x6925e9f7 CD3DBase::SetVertexShaderConstantIntF 2.37
10 functions, 152 instructions, Total: 269 samples, 49.09% of shown samples, 0.80% of total session samples
UpdateViewportCache looks like it might be low hanging fruit as well.
Review URL: http://codereview.appspot.com/4535049
------------------------------------------------------------------------
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86790
Patch Set 1 #Messages
Total messages: 2 (0 generated)
|
