Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 7076030: linux: extend the ifdefs in shell.cc to cover V8_SHARED too (Closed)

Created:
9 years, 7 months ago by Evan Martin
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

linux: extend the ifdefs in shell.cc to cover V8_SHARED too Committed: http://code.google.com/p/v8/source/detail?r=8090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M samples/shell.cc View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
9 years, 7 months ago (2011-05-26 22:53:58 UTC) #1
rvargas (doing something else)
I think it would be nice to unify the macros across OSes at some point. ...
9 years, 7 months ago (2011-05-26 23:34:16 UTC) #2
Evan Martin
On 2011/05/26 23:34:16, rvargas wrote: > I think it would be nice to unify the ...
9 years, 7 months ago (2011-05-26 23:37:57 UTC) #3
Evan Martin
ping?
9 years, 7 months ago (2011-05-27 20:37:24 UTC) #4
Mads Ager (chromium)
9 years, 6 months ago (2011-05-30 06:08:44 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698