Issue 7076027: Couple more wrench menu issues. The patch I sent around a couple of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7076027: Couple more wrench menu issues. The patch I sent around a couple of (Closed)

Created:
9 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Couple more wrench menu issues. The patch I sent around a couple of days back didn't include these: . If other bookmarks folder is empty it wouldn't show a menu item for (empty). . Deleting the last item in the other folder would prematurely close the menu. . 'always show bookmark bar' wasn't rendering the check. BUG=84167 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87031

Patch Set 1 #

Patch Set 2 : Makes unit test compile #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -25 lines)			Patch
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc	View	1	13 chunks	+14 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/wrench_menu.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages