Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 7076019: make: don't use --whole-archive for loadable_module (Closed)

Created:
9 years, 7 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

make: don't use --whole-archive for loadable_module r918 removed a hack and fixed it by introducing whole-archive. Unfortunately, our loadable module link lines include lots of stuff that doesn't belong in the loadable module. Work around that so that we're not stuck on an old version of gyp; hopefully with more investigation we can trim these link lines as well. Committed: http://code.google.com/p/gyp/source/detail?r=928

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M pylib/gyp/generator/make.py View 1 2 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
"what could possibly go wrong" Somehow nacl ends up in the link line for libipcfuzz, ...
9 years, 7 months ago (2011-05-26 17:46:27 UTC) #1
tony
9 years, 7 months ago (2011-05-26 18:10:00 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698