Issue 7076014: [cros] Initial implementation for OOBE WebUI.

Issue 7076014: [cros] Initial implementation for OOBE WebUI. (Closed)

Created:
9 years, 7 months ago by Nikita (slow)

Modified:
9 years, 6 months ago

Reviewers:
whywhat

CC:
chromium-reviews, rharrison

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros] Initial implementation for OOBE WebUI. Only C++ part and trivial HTML/CSS files. BUG=chromium-os:15632 TEST=Manual. Navigated to chrome://oobe.

Patch Set 6 : merge, revert HTML/JS/CSS changes #

Patch Set 8 : merge #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+298 lines, -7 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1 2 3 4	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 2 3 4 5 6 7	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 2 3 4	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/app/nibs/MainMenu.xib	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/resources/chromeos/oobe.css	View	1 2 3 4 5	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/chromeos/oobe.html	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_factory.cc	View	1 2 3 4 5	2 chunks	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/chromeos/login/oobe_ui.h	View		1 chunk	+27 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View	1 2 3 4 5	1 chunk	+228 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/url_constants.h	View	1 2 3 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1 2 3 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/tools/mac_helpers/infoplist_strings_util.mm	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Anton, please review C++ part and new strings. Erik, please review HTML/CSS/JS.

9 years, 7 months ago (2011-05-26 12:00:57 UTC) #1

whywhat

LGTM for C++ part http://codereview.chromium.org/7076014/diff/4001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): http://codereview.chromium.org/7076014/diff/4001/chrome/app/chromium_strings.grd#newcode194 chrome/app/chromium_strings.grd:194: Chromium > Connect Shouldn't this ...

9 years, 7 months ago (2011-05-26 19:48:47 UTC) #2

Nikita (slow)

I'm not sure whether Mac AppMenu should reuse same IDS_SHORT_PRODUCT_NAME, so leaving it as a ...

9 years, 7 months ago (2011-05-27 12:23:24 UTC) #3

Nikita (slow)

9 years, 6 months ago (2011-05-30 12:16:12 UTC) #4

I've removed HTML/JS/CSS/images changes, leaving only trivial html/css files.
This CL only contains C++ part and strings changes.

Expand Messages | Collapse Messages