Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: rietveld.py

Issue 7075029: Pass a dict when no extra_headers is specified to upload.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 """Defines class Rietveld to easily access a rietveld instance. 4 """Defines class Rietveld to easily access a rietveld instance.
5 5
6 Security implications: 6 Security implications:
7 7
8 The following hypothesis are made: 8 The following hypothesis are made:
9 - Rietveld enforces: 9 - Rietveld enforces:
10 - Nobody else than issue owner can upload a patch set 10 - Nobody else than issue owner can upload a patch set
(...skipping 30 matching lines...) Expand all
41 class Rietveld(object): 41 class Rietveld(object):
42 """Accesses rietveld.""" 42 """Accesses rietveld."""
43 def __init__(self, url, email, password, extra_headers=None): 43 def __init__(self, url, email, password, extra_headers=None):
44 self.issue = None 44 self.issue = None
45 self.url = url 45 self.url = url
46 if email and password: 46 if email and password:
47 get_creds = lambda: (email, password) 47 get_creds = lambda: (email, password)
48 self.rpc_server = upload.HttpRpcServer( 48 self.rpc_server = upload.HttpRpcServer(
49 self.url, 49 self.url,
50 get_creds, 50 get_creds,
51 extra_headers=extra_headers) 51 extra_headers=extra_headers or {})
52 else: 52 else:
53 self.rpc_server = upload.GetRpcServer(url, email) 53 self.rpc_server = upload.GetRpcServer(url, email)
54 self._xsrf_token = None 54 self._xsrf_token = None
55 self._xsrf_token_time = None 55 self._xsrf_token_time = None
56 56
57 def xsrf_token(self): 57 def xsrf_token(self):
58 if (not self._xsrf_token_time or 58 if (not self._xsrf_token_time or
59 (time.time() - self._xsrf_token_time) > 30*60): 59 (time.time() - self._xsrf_token_time) > 30*60):
60 self._xsrf_token_time = time.time() 60 self._xsrf_token_time = time.time()
61 self._xsrf_token = self.get( 61 self._xsrf_token = self.get(
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 if retry >= (maxtries - 1): 205 if retry >= (maxtries - 1):
206 raise 206 raise
207 if not 'Name or service not known' in e.reason: 207 if not 'Name or service not known' in e.reason:
208 # Usually internal GAE flakiness. 208 # Usually internal GAE flakiness.
209 raise 209 raise
210 # If reaching this line, loop again. Uses a small backoff. 210 # If reaching this line, loop again. Uses a small backoff.
211 time.sleep(1+maxtries*2) 211 time.sleep(1+maxtries*2)
212 212
213 # DEPRECATED. 213 # DEPRECATED.
214 Send = get 214 Send = get
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698