Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 7075018: Add new PDF plugin resources for print preview. (Closed)

Created:
9 years, 6 months ago by Lei Zhang
Modified:
9 years, 6 months ago
Reviewers:
jam, gene, gene1
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add new PDF plugin resources for print preview. BUG=80192 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M ppapi/c/private/ppb_pdf.h View 1 chunk +4 lines, -1 line 0 comments Download
A webkit/glue/resources/pdf_button_zoomin_end.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_zoomin_end_hover.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_zoomin_end_pressed.png View Binary file 0 comments Download
M webkit/glue/webkit_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_pdf_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
Marcin is ok with the images.
9 years, 6 months ago (2011-05-26 20:34:34 UTC) #1
gene1
9 years, 6 months ago (2011-05-26 20:44:56 UTC) #2
lgtm

On Thu, May 26, 2011 at 1:34 PM, <thestig@chromium.org> wrote:

> Reviewers: gene, John Abd-El-Malek,
>
> Message:
> Marcin is ok with the images.
>
> Description:
> Add new PDF plugin resources for print preview.
>
> BUG=80192
> TEST=none
>
> Please review this at http://codereview.chromium.org/7075018/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     ppapi/c/private/ppb_pdf.h
>  A     webkit/glue/resources/pdf_button_zoomin_end.png
>  A     webkit/glue/resources/pdf_button_zoomin_end_hover.png
>  A     webkit/glue/resources/pdf_button_zoomin_end_pressed.png
>  M     webkit/glue/webkit_resources.grd
>  M     webkit/plugins/ppapi/ppb_pdf_impl.cc
>
>
> Index: ppapi/c/private/ppb_pdf.h
> ===================================================================
> --- ppapi/c/private/ppb_pdf.h   (revision 86874)
> +++ ppapi/c/private/ppb_pdf.h   (working copy)
> @@ -62,7 +62,10 @@
>   PP_RESOURCEIMAGE_PDF_BUTTON_SAVE_PRESSED = 36,
>   PP_RESOURCEIMAGE_PDF_BUTTON_PRINT = 37,
>   PP_RESOURCEIMAGE_PDF_BUTTON_PRINT_HOVER = 38,
> -  PP_RESOURCEIMAGE_PDF_BUTTON_PRINT_PRESSED = 39
> +  PP_RESOURCEIMAGE_PDF_BUTTON_PRINT_PRESSED = 39,
> +  PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN_END = 40,
> +  PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN_END_HOVER = 41,
> +  PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN_END_PRESSED = 42,
>  } PP_ResourceImage;
>
>  typedef enum {
> Index: webkit/glue/resources/pdf_button_zoomin_end.png
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = image/png
>
> Property changes on: webkit/glue/resources/pdf_button_zoomin_end.png
> ___________________________________________________________________
> Added: svn:mime-type
>   + image/png
>
> Index: webkit/glue/resources/pdf_button_zoomin_end_hover.png
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = image/png
>
> Property changes on: webkit/glue/resources/pdf_button_zoomin_end_hover.png
> ___________________________________________________________________
> Added: svn:mime-type
>   + image/png
>
> Index: webkit/glue/resources/pdf_button_zoomin_end_pressed.png
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = image/png
>
> Property changes on:
> webkit/glue/resources/pdf_button_zoomin_end_pressed.png
> ___________________________________________________________________
> Added: svn:mime-type
>   + image/png
>
> Index: webkit/glue/webkit_resources.grd
> ===================================================================
> --- webkit/glue/webkit_resources.grd    (revision 86874)
> +++ webkit/glue/webkit_resources.grd    (working copy)
> @@ -59,6 +59,9 @@
>       <include name="IDR_PDF_BUTTON_FTW"
> file="resources\pdf_button_ftw.png" type="BINDATA" />
>       <include name="IDR_PDF_BUTTON_FTW_HOVER"
> file="resources\pdf_button_ftw_hover.png" type="BINDATA" />
>       <include name="IDR_PDF_BUTTON_FTW_PRESSED"
> file="resources\pdf_button_ftw_pressed.png" type="BINDATA" />
> +      <include name="IDR_PDF_BUTTON_ZOOMIN_END"
> file="resources\pdf_button_zoomin_end.png" type="BINDATA" />
> +      <include name="IDR_PDF_BUTTON_ZOOMIN_END_HOVER"
> file="resources\pdf_button_zoomin_end_hover.png" type="BINDATA" />
> +      <include name="IDR_PDF_BUTTON_ZOOMIN_END_PRESSED"
> file="resources\pdf_button_zoomin_end_pressed.png" type="BINDATA" />
>       <include name="IDR_PDF_BUTTON_ZOOMIN"
> file="resources\pdf_button_zoomin.png" type="BINDATA" />
>       <include name="IDR_PDF_BUTTON_ZOOMIN_HOVER"
> file="resources\pdf_button_zoomin_hover.png" type="BINDATA" />
>       <include name="IDR_PDF_BUTTON_ZOOMIN_PRESSED"
> file="resources\pdf_button_zoomin_pressed.png" type="BINDATA" />
> Index: webkit/plugins/ppapi/ppb_pdf_impl.cc
> ===================================================================
> --- webkit/plugins/ppapi/ppb_pdf_impl.cc        (revision 86874)
> +++ webkit/plugins/ppapi/ppb_pdf_impl.cc        (working copy)
> @@ -61,6 +61,11 @@
>   { PP_RESOURCEIMAGE_PDF_BUTTON_FTW, IDR_PDF_BUTTON_FTW },
>   { PP_RESOURCEIMAGE_PDF_BUTTON_FTW_HOVER, IDR_PDF_BUTTON_FTW_HOVER },
>   { PP_RESOURCEIMAGE_PDF_BUTTON_FTW_PRESSED, IDR_PDF_BUTTON_FTW_PRESSED },
> +  { PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN_END, IDR_PDF_BUTTON_ZOOMIN_END },
> +  { PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN_END_HOVER,
> +      IDR_PDF_BUTTON_ZOOMIN_END_HOVER },
> +  { PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN_END_PRESSED,
> +      IDR_PDF_BUTTON_ZOOMIN_END_PRESSED },
>   { PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN, IDR_PDF_BUTTON_ZOOMIN },
>   { PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN_HOVER, IDR_PDF_BUTTON_ZOOMIN_HOVER
> },
>   { PP_RESOURCEIMAGE_PDF_BUTTON_ZOOMIN_PRESSED,
> IDR_PDF_BUTTON_ZOOMIN_PRESSED },
> @@ -343,4 +348,3 @@
>
>  }  // namespace ppapi
>  }  // namespace webkit
> -
>
>
>

Powered by Google App Engine
This is Rietveld 408576698