Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 7075009: Double allocation size for special json strings on every resize (fixes (Closed)

Created:
9 years, 7 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Double allocation size for special json strings on every resize (fixes crbug 83877) The issue was that with the relatively small start and increment size of the string we created a ton of string handles when scanning a large string with special characters (500k+ in this case). In addition, since we can not be sure the the newly allocated string is in newspace a check is introduced and if not a filler object is inserted instead of shrinking. Committed: http://code.google.com/p/v8/source/detail?r=8082

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/json-parser.cc View 1 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
9 years, 7 months ago (2011-05-26 13:41:21 UTC) #1
William Hesse
LGTM, except that delta is wrong where noted. http://codereview.chromium.org/7075009/diff/1/src/json-parser.cc File src/json-parser.cc (right): http://codereview.chromium.org/7075009/diff/1/src/json-parser.cc#newcode455 src/json-parser.cc:455: Address ...
9 years, 7 months ago (2011-05-26 14:00:52 UTC) #2
Rico
9 years, 7 months ago (2011-05-26 14:02:56 UTC) #3
http://codereview.chromium.org/7075009/diff/1/src/json-parser.cc
File src/json-parser.cc (right):

http://codereview.chromium.org/7075009/diff/1/src/json-parser.cc#newcode455
src/json-parser.cc:455: Address start_filler_object = seq_two_byte->address() +
delta;
On 2011/05/26 14:00:52, William Hesse wrote:
> delta is not right here.  Looks good to me.

Done.

Powered by Google App Engine
This is Rietveld 408576698