Adding more commandline options and CHROME_FLAGS cleanup in media_perf test.

This change includes:
* adding -j option for track(caption) testing, 
* clean up setting CHROME_FLAGS related code
* remove the loop for media cache testing and control it directly from commandline using -c option (enable/disable media cache)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88358

[imasaki1, 2011-06-07 22:27:21]

Thanks!

[dennis_jeffrey, 2011-06-08 00:44:55]

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
File chrome/test/functional/media/media_test_runner.py (right):

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
chrome/test/functional/media/media_test_runner.py:166: # I temporary use
reference build mechanism.
"temporary" -->
"temporarily"

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
chrome/test/functional/media/media_test_runner.py:204: # the media cache (refer
to data/media/html/player.js).
Indent lines 203-204 by 1 more space each.

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
chrome/test/functional/media/media_test_runner.py:223: # The test script names
are in the PYAUTO_TEST file.
Do you mean "PYAUTO_TESTS" instead of "PYAUTO_TEST"?

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
chrome/test/functional/media/media_test_runner.py:235: chrome_flag += ' ' +
CHROME_FLAGS['track']
If the condition at line 232 above is false, and the condition at line 234 is
true, then the "chrome_flag" variable will start with a space character.  Is
that ok, or will it potentially cause a problem in line 237 below?

[imasaki1, 2011-06-08 13:25:38]

Thanks!

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
File chrome/test/functional/media/media_test_runner.py (right):

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
chrome/test/functional/media/media_test_runner.py:166: # I temporary use
reference build mechanism.
On 2011/06/08 00:44:55, dennis_jeffrey wrote:
> "temporary" -->
> "temporarily"

Done.

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
chrome/test/functional/media/media_test_runner.py:204: # the media cache (refer
to data/media/html/player.js).
On 2011/06/08 00:44:55, dennis_jeffrey wrote:
> Indent lines 203-204 by 1 more space each.

Done.

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
chrome/test/functional/media/media_test_runner.py:223: # The test script names
are in the PYAUTO_TEST file.
On 2011/06/08 00:44:55, dennis_jeffrey wrote:
> Do you mean "PYAUTO_TESTS" instead of "PYAUTO_TEST"?

Done.

http://codereview.chromium.org/7074060/diff/1/chrome/test/functional/media/me...
chrome/test/functional/media/media_test_runner.py:235: chrome_flag += ' ' +
CHROME_FLAGS['track']
On 2011/06/08 00:44:55, dennis_jeffrey wrote:
> If the condition at line 232 above is false, and the condition at line 234 is
> true, then the "chrome_flag" variable will start with a space character.  Is
> that ok, or will it potentially cause a problem in line 237 below?

Done.

[annacc, 2011-06-08 15:18:45]

I'm not too familiar with this area, but the track stuff LGTM.

[dennis_jeffrey, 2011-06-08 16:15:55]

LGTM

Thanks!

[commit-bot: I haz the power, 2011-06-08 17:53:03]

Change committed as 88358

[Nirnimesh, 2011-06-08 18:12:29]

On 2011/06/08 17:53:03, I haz the power (commit-bot) wrote:
> Change committed as 88358

FYI, Kenji you no longer have to use the Commit checkbox to commit. You can
create a writable source-tree checkout, and then you can commit using gcl commit
(Look for instructions in your commit access email)

Either way, no harm done. Just that the commit checkbox takes longer to commit.