PrintPreview: Modified PrintingContextMac code to use the copy of sharedPrintInfo object.

printing/printing_context_mac.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PRINTING_PRINTING_CONTEXT_MAC_H_
 #define PRINTING_PRINTING_CONTEXT_MAC_H_
 
 #include <string>
 
 #include "base/memory/scoped_nsobject.h"
@@ skipping 24 matching lines @@
   virtual Result InitWithSettings(const PrintSettings& settings);
   virtual Result NewDocument(const string16& document_name);
   virtual Result NewPage();
   virtual Result PageDone();
   virtual Result DocumentDone();
   virtual void Cancel();
   virtual void ReleaseContext();
   virtual gfx::NativeDrawingContext context() const;
 
  private:
-  // Read the settings from the given NSPrintInfo (and cache it for later use).
-  void ParsePrintInfo(NSPrintInfo* print_info);
+  // Reset the cached |print_info_| with |print_info|.
+  void ResetPrintInfo(NSPrintInfo* print_info);
 
-  // Initializes PrintSettings from native print info object.
+  // Initializes PrintSettings from cached print info object.

[stuartmorgan, 2011/06/02 21:07:20]

s/cached print info object/|print_info_|/

I think it would be worthwhile to add a sentence here like "This must be called
after changes to |print_info_| in order for the changes to take effect in
printing."

[kmadhusu, 2011/06/02 23:07:00]

Done.

+  // This function ignores the page range information specified in the print
+  // info object and use |ranges| instead.
   void InitPrintSettingsFromPrintInfo(const PageRanges& ranges);
 
+  // Returns the set of page ranges constructed from cached print info object.

[stuartmorgan, 2011/06/02 21:07:20]

s/cached print info object/|print_info_|/

[kmadhusu, 2011/06/02 23:07:00]

Done.

+  PageRanges GetPageRangesFromPrintInfo();
+
   // Updates |print_info_| to use the given printer.
   // Returns true if the printer was set else returns false.
   bool SetPrinter(const std::string& device_name);
 
   // Sets |copies| in PMPrintSettings.
   // Returns true if the number of copies is set.
   bool SetCopiesInPrintSettings(int copies);
 
   // Sets |collate| in PMPrintSettings.
   // Returns true if |collate| is set.
@@ skipping 17 matching lines @@
   // The current page's context; only valid between NewPage and PageDone call
   // pairs.
   CGContext* context_;
 
   DISALLOW_COPY_AND_ASSIGN(PrintingContextMac);
 };
 
 }  // namespace printing
 
 #endif  // PRINTING_PRINTING_CONTEXT_MAC_H_