Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: content/renderer/renderer_webstoragearea_impl.cc

Issue 7074022: Get rid of the render view id in localStorage IPCs as it's not used anymore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/renderer/renderer_webstoragearea_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/renderer_webstoragearea_impl.h" 5 #include "content/renderer/renderer_webstoragearea_impl.h"
6 6
7 #include "content/common/dom_storage_messages.h" 7 #include "content/common/dom_storage_messages.h"
8 #include "content/renderer/render_thread.h" 8 #include "content/renderer/render_thread.h"
9 #include "content/renderer/render_view.h" 9 #include "content/renderer/render_view.h"
10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
11 #include "third_party/WebKit/Source/WebKit/chromium/public/WebURL.h" 10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebURL.h"
12 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
13 11
14 using WebKit::WebFrame;
15 using WebKit::WebString; 12 using WebKit::WebString;
16 using WebKit::WebURL; 13 using WebKit::WebURL;
17 using WebKit::WebView;
18 14
19 RendererWebStorageAreaImpl::RendererWebStorageAreaImpl( 15 RendererWebStorageAreaImpl::RendererWebStorageAreaImpl(
20 int64 namespace_id, const WebString& origin) { 16 int64 namespace_id, const WebString& origin) {
21 RenderThread::current()->Send( 17 RenderThread::current()->Send(
22 new DOMStorageHostMsg_StorageAreaId(namespace_id, origin, 18 new DOMStorageHostMsg_StorageAreaId(namespace_id, origin,
23 &storage_area_id_)); 19 &storage_area_id_));
24 } 20 }
25 21
26 RendererWebStorageAreaImpl::~RendererWebStorageAreaImpl() { 22 RendererWebStorageAreaImpl::~RendererWebStorageAreaImpl() {
27 } 23 }
(...skipping 14 matching lines...) Expand all
42 38
43 WebString RendererWebStorageAreaImpl::getItem(const WebString& key) { 39 WebString RendererWebStorageAreaImpl::getItem(const WebString& key) {
44 NullableString16 value; 40 NullableString16 value;
45 RenderThread::current()->Send( 41 RenderThread::current()->Send(
46 new DOMStorageHostMsg_GetItem(storage_area_id_, key, &value)); 42 new DOMStorageHostMsg_GetItem(storage_area_id_, key, &value));
47 return value; 43 return value;
48 } 44 }
49 45
50 void RendererWebStorageAreaImpl::setItem( 46 void RendererWebStorageAreaImpl::setItem(
51 const WebString& key, const WebString& value, const WebURL& url, 47 const WebString& key, const WebString& value, const WebURL& url,
52 WebStorageArea::Result& result, WebString& old_value_webkit, 48 WebStorageArea::Result& result, WebString& old_value_webkit) {
53 WebFrame* web_frame) {
54 int32 render_view_id = MSG_ROUTING_CONTROL;
55 if (web_frame) {
56 RenderView* render_view = RenderView::FromWebView(web_frame->view());
57 if (render_view)
58 render_view_id = render_view->routing_id();
59 }
60 DCHECK(render_view_id != MSG_ROUTING_CONTROL);
61
62 NullableString16 old_value; 49 NullableString16 old_value;
63 RenderThread::current()->Send(new DOMStorageHostMsg_SetItem( 50 RenderThread::current()->Send(new DOMStorageHostMsg_SetItem(
64 render_view_id, storage_area_id_, key, value, url, &result, &old_value)); 51 storage_area_id_, key, value, url, &result, &old_value));
65 old_value_webkit = old_value; 52 old_value_webkit = old_value;
66 } 53 }
67 54
68 void RendererWebStorageAreaImpl::removeItem( 55 void RendererWebStorageAreaImpl::removeItem(
69 const WebString& key, const WebURL& url, WebString& old_value_webkit) { 56 const WebString& key, const WebURL& url, WebString& old_value_webkit) {
70 NullableString16 old_value; 57 NullableString16 old_value;
71 RenderThread::current()->Send( 58 RenderThread::current()->Send(
72 new DOMStorageHostMsg_RemoveItem(storage_area_id_, key, url, &old_value)); 59 new DOMStorageHostMsg_RemoveItem(storage_area_id_, key, url, &old_value));
73 old_value_webkit = old_value; 60 old_value_webkit = old_value;
74 } 61 }
75 62
76 void RendererWebStorageAreaImpl::clear( 63 void RendererWebStorageAreaImpl::clear(
77 const WebURL& url, bool& cleared_something) { 64 const WebURL& url, bool& cleared_something) {
78 RenderThread::current()->Send( 65 RenderThread::current()->Send(
79 new DOMStorageHostMsg_Clear(storage_area_id_, url, &cleared_something)); 66 new DOMStorageHostMsg_Clear(storage_area_id_, url, &cleared_something));
80 } 67 }
OLDNEW
« no previous file with comments | « content/renderer/renderer_webstoragearea_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698