Issue 7074009: Fix Win compilation issue introduced in r8081.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7074009: Fix Win compilation issue introduced in r8081. (Closed)

Created:
9 years, 7 months ago by sandholm

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix Win compilation issue introduced in r8081.

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/runtime.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Rico

http://codereview.chromium.org/7074009/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7074009/diff/1/src/runtime.cc#newcode5112 src/runtime.cc:5112: *(write_cursor++) = static_cast<SinkChar>(c); Well actually, consider making a comment ...

9 years, 7 months ago (2011-05-26 14:42:09 UTC) #3

sandholm

9 years, 6 months ago (2011-05-30 09:12:54 UTC) #4

On 2011/05/26 14:42:09, Rico wrote:
> http://codereview.chromium.org/7074009/diff/1/src/runtime.cc
> File src/runtime.cc (right):
> 
> http://codereview.chromium.org/7074009/diff/1/src/runtime.cc#newcode5112
> src/runtime.cc:5112: *(write_cursor++) = static_cast<SinkChar>(c);
> Well actually, consider making a comment why this always goes well

Agree. Added comment in a later CL.

Expand Messages | Collapse Messages