Issue 7071015: Fix the VS2005 build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7071015: Fix the VS2005 build. (Closed)

Created:
9 years, 7 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the VS2005 build. R=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86888

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	base/tracked.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

The compile error looks like: 1>tracked.cc 1>g:\b\chrome_trunk2\src\third_party\platformsdk_win7\files\Include\winnt.h(3674) : error C2733: second C linkage of overloaded ...

9 years, 7 months ago (2011-05-26 16:47:09 UTC) #1

darin (slow to review)

Some more info about this problem: http://connect.microsoft.com/VisualStudio/feedback/details/262047/compiler-error-when-including-windows-h-and-intrin-h-in-the-same-compilation-unit It seems like including intrin.h is problematic.

9 years, 7 months ago (2011-05-26 16:49:18 UTC) #2

LGTM

Expand Messages | Collapse Messages