Issue 7071005: Disable CaptureVisibleTabPng/Jpeg on platforms where they time out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7071005: Disable CaptureVisibleTabPng/Jpeg on platforms where they time out. (Closed)

Created:
9 years, 7 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Mike Mammarella, msw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable CaptureVisibleTabPng/Jpeg on platforms where they time out. BUG=83876 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86787

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	chrome/browser/extensions/extension_tabs_apitest.cc	View		2 chunks	+10 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

msw

9 years, 7 months ago (2011-05-26 07:24:43 UTC) #2

after the fact drive-by.

http://codereview.chromium.org/7071005/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tabs_apitest.cc (right):

http://codereview.chromium.org/7071005/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tabs_apitest.cc:102: #if defined(OS_LINUX)
If Jpeg is still timing out on cros, perhaps you should leave that disabled?

Expand Messages | Collapse Messages