Issue 7071003: Enable Spellcheck API on Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7071003: Enable Spellcheck API on Chromium. (Closed)

Created:
9 years, 7 months ago by Hironori Bono

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable Spellcheck API on Chromium. This change just enables the Spellcheck API implemented in <http://webkit.org/b/59693>; on Chromium by default to fix WebKit Bug 62296 <http://webkit.org/b/62296>;. BUG=http://webkit.org/b/62296 TEST=editing/spelling/spellcheck-api.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88634

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -0 lines)			Patch
M	build/features_override.gypi	View	1 chunk	+1 line, -0 lines	2 comments	Download
M	content/common/content_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/content_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

http://codereview.chromium.org/7071003/diff/1/build/features_override.gypi File build/features_override.gypi (right): http://codereview.chromium.org/7071003/diff/1/build/features_override.gypi#newcode56 build/features_override.gypi:56: 'ENABLE_SPELLCHECK_API=1', this isn't used anywhere?

9 years, 6 months ago (2011-06-09 03:13:31 UTC) #2

Hironori Bono

Greetings John, Thank you for your review and comment. To describe some more details, this ...

9 years, 6 months ago (2011-06-09 03:25:23 UTC) #3

jam

9 years, 6 months ago (2011-06-09 21:41:39 UTC) #4

lgtm (I had tried searching using cs but I guess it wasn't refreshed yet)

Expand Messages | Collapse Messages