Change "Save" to "Keep" in dangerous download confirmation prompt.

Change "Save" to "Keep" in dangerous download confirmation prompt.

BUG=80338
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87435

[Peter Kasting, 2011-05-26 01:21:31]

It seems like the associated prompting strings also need some tweaking.  "Keep"
is an odd response to "This file is malicious. Are you sure you want to
continue?" or "This type of file can harm your computer. Are you sure you want
to download foo.exe?"

Maybe something more like "This file is malicious.  Do you wish to keep it
anyway?" and "This type of file can harm your computer.  Do you wish to keep
foo.exe anyway?"

[mattm, 2011-05-26 23:27:57]

On 2011/05/26 01:21:31, Peter Kasting wrote:
> It seems like the associated prompting strings also need some tweaking. 
"Keep"
> is an odd response to "This file is malicious. Are you sure you want to
> continue?" or "This type of file can harm your computer. Are you sure you want
> to download foo.exe?"
> 
> Maybe something more like "This file is malicious.  Do you wish to keep it
> anyway?" and "This type of file can harm your computer.  Do you wish to keep
> foo.exe anyway?"

done.

[Peter Kasting, 2011-05-26 23:30:06]

LGTM.  Probably want to double-check with a tech writer.

[mattm, 2011-05-28 00:29:19]

On 2011/05/26 23:30:06, Peter Kasting wrote:
> LGTM.  Probably want to double-check with a tech writer.

updated (she liked "are you sure" more than "do you wish")

[Peter Kasting, 2011-05-28 01:14:57]

On 2011/05/28 00:29:19, mattm wrote:
> On 2011/05/26 23:30:06, Peter Kasting wrote:
> > LGTM.  Probably want to double-check with a tech writer.
> 
> updated (she liked "are you sure" more than "do you wish")

There's one problem with "are you sure", which is that these prompts can appear
without any user action or intent, and thus "are you sure" can inappropriately
imply that the user wanted to download the file to begin with.  (A primary use
case these attempt to address, in fact, is one where a web site triggers a
download without the user's knowledge.)

You might want to double-check that with the tech writer in question.

Thanks for taking the time to be careful on this one.

[mattm, 2011-06-01 04:45:23]

On 2011/05/28 01:14:57, Peter Kasting wrote:
> On 2011/05/28 00:29:19, mattm wrote:
> > On 2011/05/26 23:30:06, Peter Kasting wrote:
> > > LGTM.  Probably want to double-check with a tech writer.
> > 
> > updated (she liked "are you sure" more than "do you wish")
> 
> There's one problem with "are you sure", which is that these prompts can
appear
> without any user action or intent, and thus "are you sure" can inappropriately
> imply that the user wanted to download the file to begin with.  (A primary use
> case these attempt to address, in fact, is one where a web site triggers a
> download without the user's knowledge.)
> 
> You might want to double-check that with the tech writer in question.
> 
> Thanks for taking the time to be careful on this one.

Updated again, changed to "Do you want" instead of "Do you wish".  I'm gonna
clicky the commit button.

[commit-bot: I haz the power, 2011-06-01 05:35:13]

Change committed as 87435