Issue 7069026: Disabling the ContextMenuTest.CFSavePageAs test as the attempted fix did not work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7069026: Disabling the ContextMenuTest.CFSavePageAs test as the attempted fix did not work. (Closed)

Created:
9 years, 7 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disabling the ContextMenuTest.CFSavePageAs test as the attempted fix did not work. BUG=83114 TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86729

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome_frame/test/ui_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

9 years, 7 months ago (2011-05-25 23:44:17 UTC) #2

lg

On Wed, May 25, 2011 at 3:47 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Disabling the ContextMenuTest.CFSavePageAs test as the attempted fix did
> not
> work.
>
> BUG=83114
> TBR=amit
>
> Please review this at http://codereview.chromium.org/7069026/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/ui_test.cc
>
>
> Index: chrome_frame/test/ui_test.cc
> ===================================================================
> --- chrome_frame/test/ui_test.cc        (revision 86706)
> +++ chrome_frame/test/ui_test.cc        (working copy)
> @@ -565,7 +565,7 @@
>  }
>
>  // http://code.google.com/p/chromium/issues/detail?id=83114
> -TEST_F(ContextMenuTest, FLAKY_CFSaveLinkAs) {
> +TEST_F(ContextMenuTest, DISABLED_CFSaveLinkAs) {
>   // Please see http://code.google.com/p/chromium/issues/detail?id=60987
>   // for more information on why this test is disabled for Vista with IE7.
>   if (base::win::GetVersion() == base::win::VERSION_VISTA &&
>
>
>

Expand Messages | Collapse Messages