Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: chrome_frame/chrome_frame_npapi.cc

Issue 7069016: Chrome Frame: Fix bogus null check found by PVS Studio. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_frame_npapi.cc
diff --git a/chrome_frame/chrome_frame_npapi.cc b/chrome_frame/chrome_frame_npapi.cc
index 84e2bc70a21cb1bafbef262a9f44db6ea9b8f17f..0baab275d1d6c0582e768025804bfc81f95c92fc 100644
--- a/chrome_frame/chrome_frame_npapi.cc
+++ b/chrome_frame/chrome_frame_npapi.cc
@@ -399,7 +399,7 @@ bool ChromeFrameNPAPI::Invoke(NPObject* header, NPIdentifier name,
const NPVariant* args, uint32_t arg_count,
NPVariant* result) {
ChromeFrameNPAPI* plugin_instance = ChromeFrameInstanceFromNPObject(header);
- if (!plugin_instance && (plugin_instance->automation_client_.get()))
+ if (!plugin_instance || !plugin_instance->automation_client_.get())
return false;
bool success = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698