Issue 7069006: Prevent registerProtocolHandler for pseudo-schemes and disabled schemes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7069006: Prevent registerProtocolHandler for pseudo-schemes and disabled schemes. (Closed)

Created:
9 years, 7 months ago by koz (OOO until 15th September)

Modified:
9 years, 5 months ago

Reviewers:
tony

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Prevent registerProtocolHandler for pseudo-schemes and disabled schemes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86799

Patch Set 3 : add missing include #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. What happens if someone tries to register http/https/ftp? http://codereview.chromium.org/7069006/diff/1/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc File chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (right): http://codereview.chromium.org/7069006/diff/1/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc#newcode434 chrome/browser/ui/tab_contents/tab_contents_wrapper.cc:434: ...

9 years, 7 months ago (2011-05-25 17:42:59 UTC) #2

koz (OOO until 15th September)

9 years, 7 months ago (2011-05-25 21:40:11 UTC) #3

Thanks, Tony!

ProtocolHandlerRegistry will only register handlers for things that don't have
handlers already, so http and friends are safe (there are also some explicit
checks for this in WebKit).

http://codereview.chromium.org/7069006/diff/1/chrome/browser/ui/tab_contents/...
File chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (right):

http://codereview.chromium.org/7069006/diff/1/chrome/browser/ui/tab_contents/...
chrome/browser/ui/tab_contents/tab_contents_wrapper.cc:434:
ChildProcessSecurityPolicy::GetInstance();
On 2011/05/25 17:42:59, tony wrote:
> Nit: 4 space indent when wrapping

Done.

Expand Messages | Collapse Messages

Issue 7069006: Prevent registerProtocolHandler for pseudo-schemes and disabled schemes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix indenting #

Patch Set 3 : add missing include #

Messages