Issue 7069005: Revert 86573 - Add separate nonce version of connect calls to ChromotingScriptableObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7069005: Revert 86573 - Add separate nonce version of connect calls to ChromotingScriptableObject. (Closed)

Created:
9 years, 7 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
Do not use (sergeyu), garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 86573 - Add separate nonce version of connect calls to ChromotingScriptableObject. It causes PPAPITest.Transport failure on Vista BUG=none TEST=manual Review URL: http://codereview.chromium.org/7042022 TBR=garykac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86575

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -83 lines)			Patch
M	remoting/client/appengine/static_files/chromoting_session.js	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	remoting/client/plugin/chromoting_scriptable_object.h	View	2 chunks	+8 lines, -12 lines	0 comments	Download
M	remoting/client/plugin/chromoting_scriptable_object.cc	View	2 chunks	+43 lines, -64 lines	0 comments	Download
M	remoting/webapp/me2mom/remoting_session.js	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Do not use (sergeyu)

I enabled PPAPITest.Transport today, and it turns out to be flaky. The failure has nothing ...

9 years, 7 months ago (2011-05-25 08:10:09 UTC) #2

ukai

9 years, 7 months ago (2011-05-25 08:12:14 UTC) #3

Oh, I see.
I'll commit it back.
Thanks for the info!
ukai

On Wed, May 25, 2011 at 17:10, Sergey Ulanov <sergeyu@google.com> wrote:

> I enabled PPAPITest.Transport today, and it turns out to be flaky. The
> failure has nothing to do with this CL.
> On May 24, 2011 11:50 PM, <ukai@chromium.org> wrote:
>

Expand Messages | Collapse Messages