Only update a "not already visible" compact nav bar when we change host or scheme.

Only update a "not already visible" compact nav bar when we change host or scheme.

BUG=83755
TEST=Make sure the CompactNav bar shows up when changing hosts or scheme (e.g., from https to http) but doesn't show otherwise.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86645

[SteveT, 2011-05-25 04:30:28]

Just one question inline.

http://codereview.chromium.org/7069002/diff/1/chrome/browser/ui/views/compact...
File chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc
(right):

http://codereview.chromium.org/7069002/diff/1/chrome/browser/ui/views/compact...
chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc:339: if
(old_url.has_host() && new_url.host() == old_url.host() &&
Just checking your logic here. What is an example of an old URL with no host and
why should we always show the bar in this case?

My understanding of how Chrome (or all browsers in general) handles URLs is that
it always calculates the absolute URL from relative paths (ie-URLs with no
hosts, like "../a/b") and then stores the full URL in the location bar/tab
contents.

[MAD, 2011-05-25 13:45:29]

Since I want to NOT show the cnav when the hosts ARE the same, I want to
make sure there is a host. I don't think no host on either side (old and
new) can be seen as the same host... Right?

It might be that this never happen, and I could change the if for a DCHECK,
but I preferred to err on the safe side. :-)

OK?

On Wed, May 25, 2011 at 12:30 AM, <stevet@chromium.org> wrote:

> Just one question inline.
>
>
>
>
http://codereview.chromium.org/7069002/diff/1/chrome/browser/ui/views/compact...
> File
>
> chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc
> (right):
>
>
>
http://codereview.chromium.org/7069002/diff/1/chrome/browser/ui/views/compact...
> chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc:339:
>
> if (old_url.has_host() && new_url.host() == old_url.host() &&
> Just checking your logic here. What is an example of an old URL with no
> host and why should we always show the bar in this case?
>
> My understanding of how Chrome (or all browsers in general) handles URLs
> is that it always calculates the absolute URL from relative paths
> (ie-URLs with no hosts, like "../a/b") and then stores the full URL in
> the location bar/tab contents.
>
>
> http://codereview.chromium.org/7069002/
>

[SteveT, 2011-05-25 15:59:04]

LGTM

I too prefer to err on the safe side - just wanted to know if your check was
superfluous.

[commit-bot: I haz the power, 2011-05-25 17:08:44]

Change committed as 86645