Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6560)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_win.h

Issue 7068029: Fix residue left over from find bar when using accelerated compositing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host_view_win.h
diff --git a/chrome/browser/renderer_host/render_widget_host_view_win.h b/chrome/browser/renderer_host/render_widget_host_view_win.h
index d90487c500460a2dc34a0a50de3f7132f5646442..073e61e37dace12863bfa8bb24cbdff8e85c5f52 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_win.h
+++ b/chrome/browser/renderer_host/render_widget_host_view_win.h
@@ -75,6 +75,9 @@ class RenderWidgetHostViewWin
void CreateWnd(HWND parent);
+ // Schedule a composite no the compositor hwnd unless one was just done.
vangelis 2011/05/26 05:57:07 Is there a typo in this comment? I'm not sure wha
jbates 2011/05/26 18:21:16 Done.
+ void ScheduleComposite();
+
DECLARE_WND_CLASS_EX(kRenderWidgetHostHWNDClass, CS_DBLCLKS, 0);
BEGIN_MSG_MAP(RenderWidgetHostHWND)
@@ -268,6 +271,9 @@ class RenderWidgetHostViewWin
// Clean up the compositor window, if needed.
void CleanupCompositorWindow();
+ // Reset was_compositing_just_completed_ to false.
+ void ResetWasCompositingJustCompleted();
nduca 2011/05/25 23:42:29 s/completed/scheduled/
jbates 2011/05/26 18:21:16 Done.
+
// Whether the window should be activated.
bool IsActivatable() const;
@@ -277,6 +283,9 @@ class RenderWidgetHostViewWin
// When we are doing accelerated compositing
HWND compositor_host_window_;
+ // If a composite operation was just done.
nduca 2011/05/25 23:42:29 You migth want to explain what this means in detai
jbates 2011/05/26 18:21:16 Done.
+ bool was_compositing_just_completed_;
+
// true if the compositor host window must be hidden after the
// software renderered view is updated.
bool hide_compositor_window_at_next_paint_;
@@ -331,6 +340,9 @@ class RenderWidgetHostViewWin
// Factory used to safely scope delayed calls to ShutdownHost().
ScopedRunnableMethodFactory<RenderWidgetHostViewWin> shutdown_factory_;
+ // Factory used to safely scope calls to RenderWidgetHostViewWin methods.
+ ScopedRunnableMethodFactory<RenderWidgetHostViewWin> method_factory_;
+
// Our parent HWND. We keep a reference to it as we SetParent(NULL) when
// hidden to prevent getting messages (Paint, Resize...), and we reattach
// when shown again.

Powered by Google App Engine
This is Rietveld 408576698