Issue 7068025: Revert 86724 - Modifying the BackgroundModeManager to handle multiple profiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7068025: Revert 86724 - Modifying the BackgroundModeManager to handle multiple profiles. (Closed)

Created:
9 years, 7 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
rpetterson

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 86724 - Modifying the BackgroundModeManager to handle multiple profiles. The background mode manager is now owned by the broser The status tray is also owned by the browser process since there is only one per browser. Previously it was owned by the profile, but now that there are multiple profiles, it makes sense to have the browser process own it. Note: This CL does not unify the status tray into one icon. TEST=unittests (added BackgroundModeManagerTest::MultiProfile) BUG=80069, 82215 Review URL: http://codereview.chromium.org/6914021 TBR=rlp@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86726

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+261 lines, -506 lines)			Patch
M	chrome/browser/background_application_list_model.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/background_application_list_model.cc	View	4 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/background_mode_manager.h	View	8 chunks	+46 lines, -96 lines	0 comments	Download
M	chrome/browser/background_mode_manager.cc	View	13 chunks	+146 lines, -249 lines	0 comments	Download
M	chrome/browser/background_mode_manager_linux.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/background_mode_manager_mac.mm	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/background_mode_manager_unittest.cc	View	5 chunks	+26 lines, -79 lines	0 comments	Download
M	chrome/browser/background_mode_manager_win.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/browser_process.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	4 chunks	+0 lines, -27 lines	0 comments	Download
M	chrome/browser/profiles/profile.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	4 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/testing_browser_process.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/test/testing_browser_process.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/test/testing_profile.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/testing_profile.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages