Fix bug in history salt computation

chrome/common/visitedlink_common.cc

Index: chrome/common/visitedlink_common.cc
diff --git a/chrome/common/visitedlink_common.cc b/chrome/common/visitedlink_common.cc
index 9cd1e848a090396f1b24c6be411d24bcf57c90c9..7b32c2fb20120ba469a42f714f6396bcf9cd96fc 100644
--- a/chrome/common/visitedlink_common.cc
+++ b/chrome/common/visitedlink_common.cc
@@ -81,7 +81,13 @@ VisitedLinkCommon::Fingerprint VisitedLinkCommon::ComputeURLFingerprint(
 
   MD5Context ctx;
   MD5Init(&ctx);
-  MD5Update(&ctx, salt, sizeof(salt));
+
+  // This should really be
+  //    MD5Update(&ctx, salt, sizeof(salt) * LINK_SALT_LENGTH);
+  // but fixing this requires regenerating local databases. 4 bytes of salt
+  // should be enough for everyone.
+  MD5Update(&ctx, salt, sizeof(uint8*));

[brettw, 2011/05/25 22:39:01]

Hm, it sucks that this is different on 64 and 32 bit systems. This means the
file will be corrupted if you change bitedness, which isn't true for any other
file :(

Maybe we should just regenerate everybody's database file? I'm kind of depressed
about both of these options.

[Nico, 2011/05/25 22:41:56]

Tell me what you want (and if it's 2, a three-sentence summary on how to do
that), and I'll make it happen.

2 seems like the Right Thing, and that's usually better in the long run.

+
   MD5Update(&ctx, canonical_url, url_len * sizeof(char));
 
   MD5Digest digest;