Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9107)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_factory.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup and improve patch. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_factory.cc
index 208e265b20e4519b6c4ff1067d907c0cd66812c7..e541f29926ed3b5952ea79db3c92d398aeb297cf 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_factory.cc
@@ -104,7 +104,7 @@ static WebUIFactoryFunction GetWebUIFactoryFunction(Profile* profile,
// All platform builds of Chrome will need to have a cloud printing
// dialog as backup. It's just that on Chrome OS, it's the only
// print dialog.
- if (url.host() == chrome::kCloudPrintResourcesHost)
+ if (url.host() == chrome::kChromeUICloudPrintResourcesHost)
return &NewWebUI<ExternalHtmlDialogUI>;
// This will get called a lot to check all URLs, so do a quick check of other
@@ -115,7 +115,7 @@ static WebUIFactoryFunction GetWebUIFactoryFunction(Profile* profile,
return NULL;
if (url.host() == chrome::kChromeUISyncResourcesHost ||
- url.host() == chrome::kCloudPrintSetupHost)
+ url.host() == chrome::kChromeUICloudPrintSetupHost)
return &NewWebUI<HtmlDialogUI>;
// Special case the new tab page. In older versions of Chrome, the new tab
@@ -127,7 +127,7 @@ static WebUIFactoryFunction GetWebUIFactoryFunction(Profile* profile,
return &NewWebUI<NewTabUI>;
// Give about:about a generic Web UI so it can navigate to pages with Web UIs.
- if (url.spec() == chrome::kChromeUIAboutAboutURL)
+ if (url.host() == chrome::kChromeUIAboutHost)
return &NewWebUI<WebUI>;
// We must compare hosts only since some of the Web UIs append extra stuff
@@ -312,7 +312,7 @@ ChromeWebUIFactory::~ChromeWebUIFactory() {
}
RefCountedMemory* ChromeWebUIFactory::GetFaviconResourceBytes(
- const GURL& page_url) const {
+ const GURL& page_url) const {
// The bookmark manager is a chrome extension, so we have to check for it
// before we check for extension scheme.
if (page_url.host() == extension_misc::kBookmarkManagerId)

Powered by Google App Engine
This is Rietveld 408576698