Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits from codereview.chromium.org/7104022/. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index c61ee4c0e4a5beaa8e1ea422f5d8eeb8c63063d9..59993c2f58691a3937b64b0c63178125047d2095 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -1586,11 +1586,9 @@ bool RenderViewContextMenu::IsDevCommandEnabled(int id) const {
if (active_entry->IsViewSourceMode())
return false;
- // Don't inspect about:network, about:memory, etc.
- // However, we do want to inspect about:blank, which is often
- // used by ordinary web pages.
- if (active_entry->virtual_url().SchemeIs(chrome::kAboutScheme) &&
- !LowerCaseEqualsASCII(active_entry->virtual_url().path(), "blank"))
+ // Do not inspect Chrome URLs (chrome://network/, chrome://memory/, etc.).
+ // However, do inspect about:blank, which is often used by ordinary web pages.
+ if (active_entry->virtual_url().SchemeIs(chrome::kChromeUIScheme))
return false;
if (id == IDC_CONTENT_CONTEXT_INSPECTELEMENT) {

Powered by Google App Engine
This is Rietveld 408576698