Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9983)

Unified Diff: chrome/renderer/about_handler.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/url_constants.cc ('k') | chrome/test/automation/automation_proxy_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/about_handler.cc
diff --git a/chrome/renderer/about_handler.cc b/chrome/renderer/about_handler.cc
index e748aa13a38dc98e2bc3ed5337727b248897d4d5..de4b57aec325cee746287023d30194ab38c5bc45 100644
--- a/chrome/renderer/about_handler.cc
+++ b/chrome/renderer/about_handler.cc
@@ -1,12 +1,14 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/renderer/about_handler.h"
+#include "base/logging.h"
#include "base/process_util.h"
#include "base/threading/platform_thread.h"
#include "chrome/common/about_handler.h"
+#include "content/common/url_constants.h"
#include "googleurl/src/gurl.h"
typedef void (*AboutHandlerFuncPtr)();
@@ -23,7 +25,7 @@ static const AboutHandlerFuncPtr about_urls_handlers[] = {
// static
bool AboutHandler::MaybeHandle(const GURL& url) {
- if (url.scheme() != chrome_about_handler::kAboutScheme)
+ if (!url.SchemeIs(chrome::kChromeUIScheme))
return false;
int about_urls_handler_index = 0;
@@ -41,8 +43,7 @@ bool AboutHandler::MaybeHandle(const GURL& url) {
// static
void AboutHandler::AboutCrash() {
- int *zero = NULL;
- *zero = 0; // Null pointer dereference: kaboom!
+ CHECK(false);
}
// static
« no previous file with comments | « chrome/common/url_constants.cc ('k') | chrome/test/automation/automation_proxy_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698