Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2059)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud_unittest.cc ('k') | chrome/browser/tab_restore_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index 4b228a8ffb57b1a56f9eb3d2c2705c6c323c7850..71aa90960e0266aabc5e26d8d426dbc4270735df 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -1588,11 +1588,9 @@ bool RenderViewContextMenu::IsDevCommandEnabled(int id) const {
if (active_entry->IsViewSourceMode())
return false;
- // Don't inspect about:network, about:memory, etc.
- // However, we do want to inspect about:blank, which is often
- // used by ordinary web pages.
- if (active_entry->virtual_url().SchemeIs(chrome::kAboutScheme) &&
- !LowerCaseEqualsASCII(active_entry->virtual_url().path(), "blank"))
+ // Do not inspect Chrome URLs (chrome://network/, chrome://memory/, etc.).
+ // However, do inspect about:blank, which is often used by ordinary web pages.
+ if (active_entry->virtual_url().SchemeIs(chrome::kChromeUIScheme))
return false;
if (id == IDC_CONTENT_CONTEXT_INSPECTELEMENT) {
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud_unittest.cc ('k') | chrome/browser/tab_restore_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698