chrome/browser/extensions/extension_install_ui.cc - Issue 7068007: Revise about: and chrome: url handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_install_ui.cc

diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc

index af2dbd49c430f6d04fb2ac2521f3cf6f94dc1031..6fc8368a76a9cc660cca9a579b24a039bc43cd8b 100644

--- a/chrome/browser/extensions/extension_install_ui.cc

+++ b/chrome/browser/extensions/extension_install_ui.cc

@@ -24,7 +24,6 @@

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

-#include "chrome/browser/ui/webui/web_ui_util.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/extensions/extension_resource.h"

@@ -71,7 +70,8 @@ void ShowAppInstalledAnimation(Browser* browser, const std::string& app_id) {

// automatically show the install animation for any new apps.

for (int i = 0; i < browser->tab_count(); ++i) {

GURL url = browser->GetTabContentsAt(i)->GetURL();

- if (web_ui_util::ChromeURLHostEquals(url, chrome::kChromeUINewTabHost)) {

+ if (url.SchemeIs(chrome::kChromeUIScheme) &&

+ url.host() == chrome::kChromeUINewTabHost) {

browser->ActivateTabAt(i, false);

return;

}