chrome/browser/download/download_browsertest.cc - Issue 7068007: Revise about: and chrome: url handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_browsertest.cc

diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc

index d34ab507c2289fab88dcbec397ad2b8da7654c5f..c53817b5adad46732156ee7268a065d84fe52a52 100644

--- a/chrome/browser/download/download_browsertest.cc

+++ b/chrome/browser/download/download_browsertest.cc

@@ -1331,7 +1331,7 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, ChromeURLAfterDownload) {

ASSERT_TRUE(InitialSetup(false));

FilePath file(FILE_PATH_LITERAL("download-test1.lib"));

GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file));

- GURL flags_url(chrome::kAboutFlagsURL);

+ GURL flags_url(chrome::kChromeUIFlagsURL);

GURL extensions_url(chrome::kChromeUIExtensionsURL);

ui_test_utils::NavigateToURL(browser(), flags_url);

@@ -1356,7 +1356,7 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, ChromeURLAfterDownload) {

// As of 2011/05/22, it's crashing, so it is getting disabled.

// http://crbug.com/82278

IN_PROC_BROWSER_TEST_F(DownloadTest, DISABLED_BrowserCloseAfterDownload) {

- GURL downloads_url(chrome::kAboutFlagsURL);

+ GURL downloads_url(chrome::kChromeUIFlagsURL);

FilePath file(FILE_PATH_LITERAL("download-test1.lib"));

GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file));