Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/browser/browser_about_handler.h

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_about_handler.h
diff --git a/chrome/browser/browser_about_handler.h b/chrome/browser/browser_about_handler.h
index caaeba3bff6de25f7070b7baa905ce7e277f459c..5fa80512732bb63814fd455488d2acd51d9cb4ee 100644
--- a/chrome/browser/browser_about_handler.h
+++ b/chrome/browser/browser_about_handler.h
@@ -19,25 +19,21 @@ template <typename T> struct DefaultSingletonTraits;
class GURL;
class Profile;
-// Decides whether the given URL will be handled by the browser about handler
-// and returns true if so. On true, it may also modify the given URL to be the
-// final form (we fix up most "about:" URLs to be "chrome:" because WebKit
-// handles all "about:" URLs as "about:blank.
+// Returns true if the given URL will be handled by the browser about handler.
+// |url| should have been processed by URLFixerUpper::FixupURL, which replaces
+// the about: scheme with chrome:// for all about:foo URLs except "about:blank".
+// Some |url| host values will be replaced with their respective redirects.
//
// This is used by BrowserURLHandler.
bool WillHandleBrowserAboutURL(GURL* url, Profile* profile);
-// Register the data source for chrome://about URLs.
-// Safe to call multiple times.
-void InitializeAboutDataSource(Profile* profile);
-
// We have a few magic commands that don't cause navigations, but rather pop up
// dialogs. This function handles those cases, and returns true if so. In this
// case, normal tab navigation should be skipped.
bool HandleNonNavigationAboutURL(const GURL& url);
-// Gets the paths that are shown in about:about.
-std::vector<std::string> AboutPaths();
+// Gets the paths that are shown in chrome://chrome-urls.
+std::vector<std::string> ChromePaths();
#if defined(USE_TCMALLOC)
// A map of header strings (e.g. "Browser", "Renderer PID 123")
« no previous file with comments | « chrome/browser/automation/automation_tab_helper_browsertest.cc ('k') | chrome/browser/browser_about_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698