Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4467)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/url_constants.h

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and add extra crash URL checks. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/extension_tabs_module.cc ('K') | « chrome/common/about_handler.cc ('k') | chrome/common/url_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/url_constants.h
diff --git a/chrome/common/url_constants.h b/chrome/common/url_constants.h
index 9c7d081b69a9454fa49471efa5006e93cc58c45f..357d40e9ad98e6598ea2de19b38af96384f9f13b 100644
--- a/chrome/common/url_constants.h
+++ b/chrome/common/url_constants.h
@@ -8,6 +8,7 @@
#define CHROME_COMMON_URL_CONSTANTS_H_
#pragma once
+#include "build/build_config.h"
#include "content/common/url_constants.h"
namespace chrome {
@@ -43,14 +44,13 @@ extern const char kAboutVersionURL[];
// chrome: URLs (including schemes). Should be kept in sync with the
// components below.
-extern const char kChromeUIAboutAboutURL[];
-extern const char kChromeUIAboutCreditsURL[];
extern const char kChromeUIAboutURL[];
extern const char kChromeUIBookmarksURL[];
extern const char kChromeUIBugReportURL[];
extern const char kChromeUIConflictsURL[];
extern const char kChromeUIConstrainedHTMLTestURL[];
extern const char kChromeUICrashesURL[];
+extern const char kChromeUICreditsURL[];
extern const char kChromeUIDevToolsURL[];
extern const char kChromeUIDownloadsURL[];
extern const char kChromeUIExtensionIconURL[];
@@ -62,14 +62,15 @@ extern const char kChromeUIHistory2URL[];
extern const char kChromeUIHistoryURL[];
extern const char kChromeUIIPCURL[];
extern const char kChromeUIKeyboardURL[];
+extern const char kChromeUIMemoryRedirectURL[];
extern const char kChromeUINewTabURL[];
extern const char kChromeUIPluginsURL[];
extern const char kChromeUIPrintURL[];
extern const char kChromeUISettingsURL[];
extern const char kChromeUITextfieldsURL[];
+extern const char kChromeUIVersionURL[];
#if defined(OS_CHROMEOS)
-extern const char kChromeUIAboutOSCreditsURL[];
extern const char kChromeUIActivationMessage[];
extern const char kChromeUIActiveDownloadsURL[];
extern const char kChromeUIChooseMobileNetworkURL[];
@@ -79,6 +80,7 @@ extern const char kChromeUIImageBurnerURL[];
extern const char kChromeUIKeyboardOverlayURL[];
extern const char kChromeUIMediaplayerURL[];
extern const char kChromeUIMobileSetupURL[];
+extern const char kChromeUIOSCreditsURL[];
extern const char kChromeUIProxySettingsURL[];
extern const char kChromeUIRegisterPageURL[];
extern const char kChromeUISlideshowURL[];
@@ -88,48 +90,87 @@ extern const char kChromeUIUserImageURL[];
extern const char kChromeUIEnterpriseEnrollmentURL[];
#endif
-// chrome components of URLs. Should be kept in sync with the full URLs
-// above.
+// chrome components of URLs. Should be kept in sync with the full URLs above.
+extern const char kChromeUIAboutHost[];
+extern const char kChromeUIAppCacheInternalsHost[];
+extern const char kChromeUIBlankHost[];
+extern const char kChromeUIBlobInternalsHost[];
extern const char kChromeUIBookmarksHost[];
+extern const char kChromeUIBrowserCrashHost[];
extern const char kChromeUIBugReportHost[];
+extern const char kChromeUICacheHost[];
+extern const char kChromeUICloudPrintResourcesHost[];
+extern const char kChromeUICloudPrintSetupHost[];
extern const char kChromeUIConflictsHost[];
+extern const char kChromeUIConstrainedHTMLTestHost[];
+extern const char kChromeUICrashHost[];
extern const char kChromeUICrashesHost[];
+extern const char kChromeUICreditsHost[];
+extern const char kChromeUIDefaultHost[];
extern const char kChromeUIDevToolsHost[];
extern const char kChromeUIDialogHost[];
+extern const char kChromeUIDNSHost[];
extern const char kChromeUIDownloadsHost[];
extern const char kChromeUIExtensionIconHost[];
extern const char kChromeUIExtensionsHost[];
extern const char kChromeUIFaviconHost[];
-extern const char kChromeUITouchIconHost[];
extern const char kChromeUIFlagsHost[];
extern const char kChromeUIFlashHost[];
+extern const char kChromeUIGpuHost[];
+extern const char kChromeUIGpuCleanHost[];
+extern const char kChromeUIGpuCrashHost[];
+extern const char kChromeUIGpuHangHost[];
extern const char kChromeUIGpuInternalsHost[];
+extern const char kChromeUIHangHost[];
extern const char kChromeUIHistory2Host[];
extern const char kChromeUIHistoryHost[];
+extern const char kChromeUIHistogramsHost[];
+extern const char kChromeUIIPCHost[];
extern const char kChromeUIKeyboardHost[];
+extern const char kChromeUIKillHost[];
+extern const char kChromeUIMemoryHost[];
+extern const char kChromeUIMemoryRedirectHost[];
extern const char kChromeUINetInternalsHost[];
+extern const char kChromeUINetworkViewCacheHost[];
extern const char kChromeUINewTabHost[];
extern const char kChromeUIPluginsHost[];
extern const char kChromeUIPrintHost[];
extern const char kChromeUIResourcesHost[];
-extern const char kChromeUIScreenshotPath[];
extern const char kChromeUISettingsHost[];
+extern const char kChromeUIShorthangHost[];
+extern const char kChromeUIStatsHost[];
+extern const char kChromeUISyncHost[];
extern const char kChromeUISyncInternalsHost[];
extern const char kChromeUISyncResourcesHost[];
+extern const char kChromeUITasksHost[];
+extern const char kChromeUITCMallocHost[];
extern const char kChromeUITextfieldsHost[];
+extern const char kChromeUITermsHost[];
+extern const char kChromeUITouchIconHost[];
+extern const char kChromeUIVersionHost[];
+
+extern const char kChromeUIScreenshotPath[];
extern const char kChromeUIThemePath[];
extern const char kChromeUIThumbnailPath[];
+#if defined(OS_LINUX)
+extern const char kChromeUILinuxProxyConfigHost[];
+extern const char kChromeUISandboxHost[];
+#endif
+
#if defined(OS_CHROMEOS)
-extern const char kChromeUIActiveDownloadsHost[];
extern const char kChromeUIActivationMessageHost[];
+extern const char kChromeUIActiveDownloadsHost[];
extern const char kChromeUIChooseMobileNetworkHost[];
extern const char kChromeUICollectedCookiesHost[];
+extern const char kChromeUIEnterpriseEnrollmentHost[];
extern const char kChromeUIHttpAuthHost[];
extern const char kChromeUIImageBurnerHost[];
extern const char kChromeUIKeyboardOverlayHost[];
extern const char kChromeUIMediaplayerHost[];
extern const char kChromeUIMobileSetupHost[];
+extern const char kChromeUINetworkHost[];
+extern const char kChromeUIOSCreditsHost[];
extern const char kChromeUIProxySettingsHost[];
extern const char kChromeUIRegisterPageHost[];
extern const char kChromeUISlideshowHost[];
@@ -139,7 +180,8 @@ extern const char kChromeUIMenu[];
extern const char kChromeUIWrenchMenu[];
extern const char kChromeUINetworkMenu[];
extern const char kChromeUIUserImageHost[];
-extern const char kChromeUIEnterpriseEnrollmentHost[];
+
+extern const char kEULAPathFormat[];
#endif
#if defined(OS_CHROMEOS) && defined(TOUCH_UI)
@@ -155,8 +197,6 @@ extern const char kBlobViewInternalsURL[];
// Cloud Print dialog URL components.
extern const char kCloudPrintResourcesURL[];
-extern const char kCloudPrintResourcesHost[];
-extern const char kCloudPrintSetupHost[];
// Network related URLs.
extern const char kNetworkViewCacheURL[];
« chrome/browser/extensions/extension_tabs_module.cc ('K') | « chrome/common/about_handler.cc ('k') | chrome/common/url_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698