Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: chrome/browser/ui/webui/options/about_page_handler.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and add extra crash URL checks. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/about_page_handler.cc
diff --git a/chrome/browser/ui/webui/options/about_page_handler.cc b/chrome/browser/ui/webui/options/about_page_handler.cc
index 70b8216315d47469d791bfe26d91d5194162ee9a..04f43b4321c65a04b3051d06f9a844957b1581c6 100644
--- a/chrome/browser/ui/webui/options/about_page_handler.cc
+++ b/chrome/browser/ui/webui/options/about_page_handler.cc
@@ -187,16 +187,14 @@ void AboutPageHandler::GetLocalizedValues(DictionaryValue* localized_strings) {
localized_strings->SetString(chromium_url_appears_first ?
"license_link_0" : "license_link_1", url.spec());
- // The Open Source link within the main text of the dialog. We need to use
- // the chrome:// variant instead of about:credits; the latter will get
- // rewritten to about:blank.
+ // The Open Source link within the main text of the dialog.
localized_strings->SetString(chromium_url_appears_first ?
"license_link_content_1" : "license_link_content_0",
StringSubRange(text,
text.find(kBeginLinkOss) + strlen(kBeginLinkOss),
text.find(kEndLinkOss)));
localized_strings->SetString(chromium_url_appears_first ?
- "license_link_1" : "license_link_0", chrome::kChromeUIAboutCreditsURL);
+ "license_link_1" : "license_link_0", chrome::kChromeUICreditsURL);
#if defined(OS_CHROMEOS)
std::string cros_text =
@@ -215,7 +213,7 @@ void AboutPageHandler::GetLocalizedValues(DictionaryValue* localized_strings) {
StringSubRange(cros_text, cros_link + strlen(kBeginLinkCrosOss),
cros_link_end));
localized_strings->SetString("cros_license_link_0",
- chrome::kChromeUIAboutOSCreditsURL);
+ chrome::kChromeUIOSCreditsURL);
#endif
// webkit

Powered by Google App Engine
This is Rietveld 408576698