Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: chrome/browser/browser_about_handler_unittest.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_about_handler_unittest.cc
diff --git a/chrome/browser/browser_about_handler_unittest.cc b/chrome/browser/browser_about_handler_unittest.cc
index 9b305509eabd53b7e1318776c195aec09a127864..d78d731623a97fc026f85297aff43b640684b83b 100644
--- a/chrome/browser/browser_about_handler_unittest.cc
+++ b/chrome/browser/browser_about_handler_unittest.cc
@@ -89,17 +89,59 @@ TEST_F(BrowserAboutHandlerTest, WillHandleBrowserAboutURL) {
false
},
{
- GURL("about:memory"),
- GURL("chrome://about/memory-redirect"),
+ GURL(chrome::kAboutMemoryURL),
+ GURL(std::string("chrome://") + chrome::kChromeUIMemoryHost),
false,
true
},
{
- GURL("about:mars"),
- GURL("chrome://about/mars"),
+ GURL(std::string("about:")),
+ GURL(std::string("chrome://") + chrome::kChromeUIVersionHost),
false,
true
},
+ {
+ GURL(std::string("chrome://") + chrome::kChromeUICacheHost),
+ GURL(std::string("chrome://") + chrome::kChromeUINetworkViewCacheHost),
+ false,
+ true
+ },
+ {
+ GURL(std::string("chrome://") + chrome::kChromeUIGpuHost),
+ GURL(std::string("chrome://") + chrome::kChromeUIGpuInternalsHost),
+ false,
+ true
+ },
+ {
+ GURL(std::string("chrome://") + chrome::kChromeUISyncHost),
+ GURL(std::string("chrome://") + chrome::kChromeUISyncInternalsHost),
+ false,
+ true
+ },
+ {
+ GURL("about:host/path?query#ref"),
+ GURL("chrome://host/path?query#ref"),
+ false,
+ true
+ },
+ {
+ GURL("about://host/path?query#ref"),
+ GURL("chrome://host/path?query#ref"),
+ false,
+ true
+ },
+ {
+ GURL("chrome:host/path?query#ref"),
+ GURL("chrome://host/path?query#ref"),
+ false,
+ true
+ },
+ {
+ GURL("chrome://host/path?query#ref"),
+ GURL("chrome://host/path?query#ref"),
+ false,
+ true
+ }
};
MessageLoopForUI message_loop;
BrowserThread ui_thread(BrowserThread::UI, &message_loop);

Powered by Google App Engine
This is Rietveld 408576698