Revise about: and chrome: url handling.

chrome/browser/ui/webui/web_ui_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_WEB_UI_UTIL_H_
 #define CHROME_BROWSER_UI_WEBUI_WEB_UI_UTIL_H_
 #pragma once
 
 #include <string>
 
 class GURL;
 class SkBitmap;
 
 namespace web_ui_util {
 
 // Convenience routine to convert SkBitmap object to data url
 // so that it can be used in WebUI.
 std::string GetImageDataUrl(const SkBitmap& bitmap);
 
 // Convenience routine to get data url that corresponds to given
 // resource_id as an image. This function does not check if the
 // resource for the |resource_id| is an image, therefore it is the
 // caller's responsibility to make sure the resource is indeed an
 // image. Returns empty string if a resource does not exist for given
 // |resource_id|.
 std::string GetImageDataUrlFromResource(int resource_id);
 
+// Returns true if |url| has a chrome: or about: scheme.
+bool IsChromeURL(const GURL& url);
+
+// GURL typically parses "scheme://host/path?query#ref" correctly, however:
+// If chrome: omits scheme separator slashes, e.g. "chrome:host/path?query#ref",
+// then GURL reports that the URL has no host and path "host/path?qry#ref".
+// If about: has scheme separator slashes, e.g. "about://host/path?query#ref",
+// then GURL reports that the URL has no host and path "//host/path?qry#ref".
+// These functions parse common about and chrome URL formats as intended.
+std::string GetChromeURLHost(const GURL& url);
+std::string GetChromeURLPath(const GURL& url);

[abarth-chromium, 2011/05/27 17:19:25]

Should we fix GURL to get these cases right instead of re-inventing URL parsing
in chrome/browser/ui ?

[msw, 2011/05/31 13:34:29]

I rewrote this as URLFixerUpper::FixupChromeURL. I'm waiting to hear from
mmentovai if such a change could be up-streamed to GURL.

+
+// Returns true if |url|'s host matches |host|.
+bool HostEquals(const GURL& url, const char* host);
+
 // Returns true if |url| has a chrome: or about: scheme and matching |host|.
 // The url may contain a path under the host.
 bool ChromeURLHostEquals(const GURL& url, const char* host);
 
 }  // namespace web_ui_util
 
 #endif  // CHROME_BROWSER_UI_WEBUI_WEB_UI_UTIL_H_