Revise about: and chrome: url handling.

content/browser/site_instance_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
 #include "base/stl_util-inl.h"
 #include "base/string16.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/test/testing_profile.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/browsing_instance.h"
 #include "content/browser/child_process_security_policy.h"
 #include "content/browser/content_browser_client.h"
 #include "content/browser/renderer_host/browser_render_process_host.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/renderer_host/test_render_view_host.h"
 #include "content/browser/site_instance.h"
 #include "content/browser/tab_contents/navigation_entry.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/browser/webui/empty_web_ui_factory.h"
 #include "content/common/content_client.h"
 #include "content/common/url_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
-// TODO(estade): this shouldn't need to be chrome:, but it does (or else GURL
-// doesn't think that the webui URLs have a host). Figure out where this is
-// coming from and fix it.
-const char kWebUIScheme[] = "chrome";
 const char kSameAsAnyInstanceURL[] = "about:internets";
 
 class SiteInstanceTestWebUIFactory : public content::EmptyWebUIFactory {
  public:
   virtual bool UseWebUIForURL(Profile* profile, const GURL& url) const {
     return HasWebUIScheme(url);
   }
   virtual bool HasWebUIScheme(const GURL& url) const {
-    return url.SchemeIs(kWebUIScheme);
+    return url.SchemeIs(chrome::kChromeUIScheme);
   }
 };
 
 class SiteInstanceTestBrowserClient : public content::ContentBrowserClient {
  public:
   virtual content::WebUIFactory* GetWebUIFactory() OVERRIDE {
     return &factory_;
   }
 
   virtual bool IsURLSameAsAnySiteInstance(const GURL& url) OVERRIDE {
-    return url.spec() == kSameAsAnyInstanceURL;
+    return url == GURL(kSameAsAnyInstanceURL) ||
+           url == GURL(chrome::kAboutCrashURL);
   }
 
  private:
   SiteInstanceTestWebUIFactory factory_;
 };
 
 class SiteInstanceTest : public testing::Test {
  public:
   SiteInstanceTest()
       : ui_thread_(BrowserThread::UI, &message_loop_),
@@ skipping 424 matching lines @@
 
   scoped_refptr<SiteInstance> extension2_instance(
       CreateSiteInstance(&rph_factory, GURL("chrome-extension://baz/bar")));
 
   scoped_ptr<RenderProcessHost> extension_host(
       extension1_instance->GetProcess());
   EXPECT_EQ(extension1_instance->GetProcess(),
             extension2_instance->GetProcess());
 
   // Create some WebUI instances and make sure they share a process.
-  scoped_refptr<SiteInstance> webui1_instance(
-      CreateSiteInstance(&rph_factory,
-                         GURL(kWebUIScheme + std::string("://newtab"))));
+  scoped_refptr<SiteInstance> webui1_instance(CreateSiteInstance(&rph_factory,
+      GURL(chrome::kChromeUIScheme + std::string("://newtab"))));
   policy->GrantWebUIBindings(webui1_instance->GetProcess()->id());
 
-  scoped_refptr<SiteInstance> webui2_instance(
-      CreateSiteInstance(&rph_factory,
-                         GURL(kWebUIScheme + std::string("://history"))));
+  scoped_refptr<SiteInstance> webui2_instance( CreateSiteInstance(&rph_factory,
+      GURL(chrome::kChromeUIScheme + std::string("://history"))));
 
   scoped_ptr<RenderProcessHost> dom_host(webui1_instance->GetProcess());
   EXPECT_EQ(webui1_instance->GetProcess(), webui2_instance->GetProcess());
 
   // Make sure none of differing privilege processes are mixed.
   EXPECT_NE(extension1_instance->GetProcess(), webui1_instance->GetProcess());
 
   for (size_t i = 0; i < chrome::kMaxRendererProcessCount; ++i) {
     EXPECT_NE(extension1_instance->GetProcess(), hosts[i]);
     EXPECT_NE(webui1_instance->GetProcess(), hosts[i]);
@@ skipping 61 matching lines @@
       GURL("chrome-extension://baz/bar")));
   EXPECT_EQ(s5a, s5b);
 
   // The derived profiles with the different sites.
   scoped_refptr<SiteInstance> s6a(instance1->GetSiteInstanceForURL(
       GURL("chrome-extension://baz/bar")));
   scoped_refptr<SiteInstance> s6b(instance3->GetSiteInstanceForURL(
       GURL("chrome-extension://foo/boo")));
   EXPECT_NE(s6a, s6b);
 }